Add tests to cover features implemented in bug 1533679 and bug 1533682
Categories
(Remote Protocol :: Agent, enhancement, P1)
Tracking
(Not tracked)
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(5 files, 1 obsolete file)
Bug 1533679 implemented support for puppeteer connect method. From CDP perspective, it means supporting:
- /json/version http endpoint,
- the main process target.
Bug 1533682 implemented basic support for puppeteer Browser.newPage. From CDP persective, it means supporting:
- sessions via sessionId attribute on JSON packets,
- a few methods and events on Target,
- a few events on Page.
|
Assignee | |
Comment 1•6 years ago
|
||
In this revision it only helps sharing handle.
But in a followup changeset, it will also help closing all the connections
and justify the sessions map we keep around.
|
|
Assignee | |
Comment 2•6 years ago
|
||
This fixes the browser mochitest which currently timesout when calling server.close()
It started to timeout when the patch related to websocket handshake landed.
Depends on D24219
|
|
Assignee | |
Comment 3•6 years ago
|
||
Doing this helps fixing the main target's path which is meant to be:
/devtools/browser
Depends on D24220
|
|
Assignee | |
Comment 4•6 years ago
|
||
Depends on D24221
|
|
Assignee | |
Comment 5•6 years ago
|
||
Depends on D24222
|
|
Assignee | |
Comment 6•6 years ago
|
||
Depends on D24223
|
||
Updated•6 years ago
|
|
||
Updated•6 years ago
|
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f3f1a5f9f403
https://hg.mozilla.org/mozilla-central/rev/ad30588da467
https://hg.mozilla.org/mozilla-central/rev/ff655425368c
https://hg.mozilla.org/mozilla-central/rev/77a5006e4f17
https://hg.mozilla.org/mozilla-central/rev/d8882582edc8
|
||
Comment 8•2 years ago
|
||
(In reply to Cristina Coroiu [:ccoroiu] from comment #7)
https://hg.mozilla.org/mozilla-central/rev/f3f1a5f9f403
https://hg.mozilla.org/mozilla-central/rev/ad30588da467
https://benkimimgkhn.blogspot.com/
https://hg.mozilla.org/mozilla-central/rev/ff655425368c
https://hg.mozilla.org/mozilla-central/rev/77a5006e4f17
https://hg.mozilla.org/mozilla-central/rev/d8882582edc8
Thanks
Description
•