Open Bug 1536838 Opened 6 years ago Updated 2 years ago

this.docShell is null errors in PictureInPictureChild.jsm when shutting down

Categories

(Toolkit :: Picture-in-Picture, enhancement, P3)

Product:
Toolkit
Component:
Picture-in-Picture
Type:
enhancement

Tracking

()

People

(Reporter: mconley, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [pip-needs-eng-triage])

This line is throwing errors: https://searchfox.org/mozilla-central/rev/358f816f63da072145c593e9e2ac36b7250ecd25/toolkit/actors/PictureInPictureChild.jsm#39

I see this if we shut down the browser with a Picture-in-Picture window open.

More STR (from jaws)

  1. Load a video on YouTube
  2. Hit Play
  3. Double right-click on the video and choose Picture-in-Picture
  4. Double right-click on the video again and choose Picture-in-Picture to close it
  5. Reload the tab

@mike What's the risk if we ship this?

Flags: needinfo?(mconley)

Very little. It's a spurious error, but there aren't any user-visible effects from it beyond the log message. It'd be good to clean up though.

Flags: needinfo?(mconley)
Blocks: videopip
No longer blocks: 1527926
Component: Video/Audio Controls → Picture-in-Picture
Version: unspecified → Trunk
Whiteboard: [pip-needs-eng-triage]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.