User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

Type anything into the search box, then press Ctrl+Up/Down to switch search engines

Actual results:

Nothing

Expected results:

The search engine should have changed.
I use this feature because the autocomplete only works for the default search engine, so if e.g. I want to see the autocomplete for Wikipedia as opposed to Google, this is the quickest way to change it.

hi mike, could you take a look here - this issue seems to have been introduced with the search related changes from bug 1524593. thank you

I also updated the logic to properly cycle through the visible search engines list
and added a unit test that was missing, somehow. This feature doesn't work on
OSX, I'm not sure why.

https://hg.mozilla.org/mozilla-central/rev/7b0b131d1b7d

Comment on attachment 9054437 [details]
Bug 1537117 - Update the search engine quick-switching functionality to work with an async SearchService API. r?florian!

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1524593
• User impact if declined: Users will notice that using Ctrl+up/down in the searchbar to quickly switching between search engines no longer works.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This feature hasn't been covered by automated tests before and this changeset fixes that so it's less likely to regress in the future. The amount of changes needed were minimal and quite obvious, really.
• String changes made/needed: n/a

Can we get that verified on Nightly before uplifting? Thanks.

I've been following 1518335 which this bug report seems to be a dupe of.

Anyway, I can confirm the bug is fixed on Nightly 68.0a1 (2019-04-02) (64-bit)

Thanks Arvid for checking!
I can confirm also this issue is verified fixed on Fx 68.0a1 (2019-04-04) across platforms (Windows 10 x64, Ubunutu 18.04 x64 and macOS 10.13).

Comment on attachment 9054437 [details]
Bug 1537117 - Update the search engine quick-switching functionality to work with an async SearchService API. r?florian!

Fix for a P1 in our Search component, with tests, verified by QE in Nightly, uplift approved for 67 beta 9, thanks.

https://hg.mozilla.org/releases/mozilla-beta/rev/73fa8de4eb47

This issue is also verified fixed with Fx 67.0b9 (20190408123043) on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 x64.