Options page / Options button should not be displayed for add-ons not allowed in Private Browsing mode
Categories
(WebExtensions :: Frontend, defect, P1)
Tracking
(firefox67 verified, firefox68 verified)
People
(Reporter: juraj.masiar, Assigned: rpl)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
|
(deleted),
video/mp4
|
Details | |
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
|
(deleted),
image/gif
|
Details | |
|
(deleted),
image/gif
|
Details |
Bug1537542.gif
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
Steps to reproduce:
See the video.
- Using FF 67, open Private Browsing window
- open about:addons
- click Options button for any of your add-ons that is not allowed in Private Browsing
Actual results:
None of the Options page would work while the add-on is not allowed in Private Browsing.
Expected results:
The "Options" button or the inline Options in the detail should not be available unless addon is allowed in Private Browsing mode.
|
||
Updated•5 years ago
|
|
|
||
Comment 2•5 years ago
|
||
STR
- install "Duplicate Tabs Closer"
- open private window
- go to about:addons, choose extensions
- is preferences button on the add in the list?
- enter details for addon
- look for preferences button bottom left
Expected:
not present in either case
Actual:
present, and opening causes an unusable preferences tab for the addon
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
Pushed by luca.greco@alcacoop.it: https://hg.mozilla.org/integration/autoland/rev/6e7b485a2f31 Hide addon preferences if the addon cannot access the current window. r=aswan
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
|
||
Comment 6•5 years ago
|
||
Comment on attachment 9052926 [details]
Bug 1537542 - Hide addon preferences if the addon cannot access the current window. r?aswan!,mixedpuppy
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: Bug 1380809
- User impact if declined: Potential failures when opening about:addons in private windows.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: STR in comment 2
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): covered by tests, minimal changes in about:addons.
- String changes made/needed: none
|
|
||
Updated•5 years ago
|
This issue is verified as fixed on Firefox 68.0a1 (20190327175114) under Win 7 64-bit and Mac OS X 10.14.1.
Please see the attached video.
|
||
Comment 8•5 years ago
|
||
Comment on attachment 9052926 [details]
Bug 1537542 - Hide addon preferences if the addon cannot access the current window. r?aswan!,mixedpuppy
P1 for a new 67 feature, verified by QA on nightly, patch with tests, uplift approved for 67 beta 6, thanks.
|
||
Comment 9•5 years ago
|
||
| bugherder uplift | ||
|
||
Comment 10•5 years ago
|
||
https://hg.mozilla.org/projects/ash/rev/6e7b485a2f314633b7f059095207ad3655d83759 Bug 1537542 - Hide addon preferences if the addon cannot access the current window. r=aswan
|
||
Comment 11•5 years ago
|
||
This issue is verified as fixed on Firefox 67.0b6 (20190328152334) under Win 7 64-bit and Mac OS X 10.14.1.
Please see the attached video.
|
||
Updated•5 years ago
|
Description
•