Closed
Bug 1537643
Opened 6 years ago
Closed 6 years ago
Avoid using MSVC from rust build scripts
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox68 fixed)
RESOLVED
FIXED
mozilla68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: glandium, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
I don't know which one yet, but I've seen a build_script_build invoking lib.exe. My guess is lmdb-sys. With chance, this only requires setting some environment variable in config/makefiles/rust.mk.
Reporter | ||
Comment 1•6 years ago
|
||
I was close enough. It was lmdb-rkv-sys, but also bzip2-sys.
The bad news is, AFAICT, the cc crate doesn't allow to override lib.exe from the environment.
Flags: needinfo?(acrichton)
Comment 2•6 years ago
|
||
Hm could you clarify what needs information for this? Is this a feature reuqest for cc to override lib.exe?
Flags: needinfo?(acrichton)
Reporter | ||
Comment 3•6 years ago
|
||
I guess this could be phrased like that. Would you prefer a github issue?
Flags: needinfo?(acrichton)
Comment 4•6 years ago
|
||
Ah yeah, a github issues would be good to track it!
Flags: needinfo?(acrichton)
Reporter | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
This update from the official sources brings in the changes that we were
using glandium's fork for, as well as changes enabling us to tweak more
settings on Windows.
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b9e5f4b0589
update cc crate; r=glandium
Comment 9•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Updated•6 years ago
|
Assignee: nobody → nfroyd
You need to log in
before you can comment on or make changes to this bug.
Description
•