This bug is for crash report bp-d81c689f-75e4-4f0a-9fcc-4f9d10190321.

Top 10 frames of crashing thread:

0 xul.dll dav1d_sgr_box5_v_ssse3 
1 xul.dll static void sgr_filter_ssse3 media/libdav1d/asm/8bd_looprestoration_init_tmpl.c:209
2 xul.dll static void lr_stripe media/libdav1d/8bd_lr_apply_tmpl.c:195
3 xul.dll static void lr_sbrow media/libdav1d/8bd_lr_apply_tmpl.c:272
4 xul.dll dav1d_lr_sbrow_8bpc media/libdav1d/8bd_lr_apply_tmpl.c:294
5 xul.dll dav1d_filter_sbrow_8bpc media/libdav1d/8bd_recon_tmpl.c:1646
6 xul.dll dav1d_decode_frame third_party/dav1d/src/decode.c:2921
7 xul.dll dav1d_frame_task third_party/dav1d/src/thread_task.c:44
8 xul.dll static unsigned int thread_entrypoint third_party/dav1d/src/win32/thread.c:40
9 ucrtbase.dll _o____lc_collate_cp_func 

There are 2 crashes (from 2 installations) in nightly 68 with buildid 20190320112939. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1533559.

[1] https://hg.mozilla.org/mozilla-central/rev?node=4f6d8ed9e948

It has been reported upstream in https://code.videolan.org/videolan/dav1d/issues/265

These crashes, in 68, have not appeared for the last buildid's. They stopped after the dav1d import which landed in Bug 1533559. I'll wait till Monday to make sure that this is the case.

(In reply to Alex Chronopoulos [:achronop] from comment #2)

These crashes, in 68, have not appeared for the last buildid's. They stopped after the dav1d import which landed in Bug 1533559. I'll wait till Monday to make sure that this is the case.

The dav1d import landed in mozilla-central on March 19 and the crashes in this bug started on March 21 and we still have crashes with 20190324094708. It seems to me that the dav1d import to 0.2.1 caused these crashes, it didn't solve them. Alex can you investigate please?

Yeah, I am looking at them, this bug contains many signatures, some of them haven't appeared after March 19. However, some other started then as you said.

Also dav1d_emu_edge_ssse3, dav1d_put_bilin_avx2 are happening only in beta which has the old version of dav1d. My guess for now is that the dav1d's update solved some of them and created some new.

Backed out for bustages on libdav1d/moz.build

backout: https://hg.mozilla.org/integration/autoland/rev/cdfe20cb4f0049d78614290f7bbe17302a92b2e0

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=abf6af5e36d6943ed5b1d81e1da49733f7077ba7&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=236068094&repo=autoland&lineNumber=1611

[task 2019-03-26T09:30:40.805Z] 09:30:40 INFO - Creating config.status
[task 2019-03-26T09:30:40.805Z] 09:30:40 INFO - Reticulating splines...
[task 2019-03-26T09:30:40.805Z] 09:30:40 ERROR - Traceback (most recent call last):
[task 2019-03-26T09:30:40.805Z] 09:30:40 INFO - File "/builds/worker/workspace/build/src/configure.py", line 132, in <module>
[task 2019-03-26T09:30:40.805Z] 09:30:40 INFO - sys.exit(main(sys.argv))
[task 2019-03-26T09:30:40.805Z] 09:30:40 INFO - File "/builds/worker/workspace/build/src/configure.py", line 43, in main
[task 2019-03-26T09:30:40.805Z] 09:30:40 INFO - return config_status(config)
[task 2019-03-26T09:30:40.805Z] 09:30:40 INFO - File "/builds/worker/workspace/build/src/configure.py", line 127, in config_status
[task 2019-03-26T09:30:40.806Z] 09:30:40 INFO - return config_status(args=[], **encode(sanitized_config, encoding))
[task 2019-03-26T09:30:40.806Z] 09:30:40 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/config_status.py", line 143, in config_status
[task 2019-03-26T09:30:40.806Z] 09:30:40 INFO - definitions = list(definitions)
[task 2019-03-26T09:30:40.806Z] 09:30:40 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/frontend/emitter.py", line 173, in emit
[task 2019-03-26T09:30:40.806Z] 09:30:40 INFO - for out in output:
[task 2019-03-26T09:30:40.807Z] 09:30:40 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/frontend/reader.py", line 885, in read_topsrcdir
[task 2019-03-26T09:30:40.807Z] 09:30:40 INFO - for r in self.read_mozbuild(path, self.config):
[task 2019-03-26T09:30:40.807Z] 09:30:40 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/frontend/reader.py", line 1052, in read_mozbuild
[task 2019-03-26T09:30:40.807Z] 09:30:40 INFO - raise bre
[task 2019-03-26T09:30:40.807Z] 09:30:40 INFO - mozbuild.frontend.reader.BuildReaderError:
[task 2019-03-26T09:30:40.807Z] 09:30:40 INFO - ==============================
[task 2019-03-26T09:30:40.807Z] 09:30:40 INFO - FATAL ERROR PROCESSING MOZBUILD FILE
[task 2019-03-26T09:30:40.807Z] 09:30:40 INFO - ==============================
[task 2019-03-26T09:30:40.807Z] 09:30:40 INFO - The error occurred while processing the following file:
[task 2019-03-26T09:30:40.807Z] 09:30:40 INFO - /builds/worker/workspace/build/src/media/libdav1d/moz.build
[task 2019-03-26T09:30:40.807Z] 09:30:40 INFO - A moz.build file called the error() function.
[task 2019-03-26T09:30:40.807Z] 09:30:40 INFO - The error it encountered is:
[task 2019-03-26T09:30:40.807Z] 09:30:40 INFO - Stack alignment cannot be zero.
[task 2019-03-26T09:30:40.808Z] 09:30:40 INFO - Correct the error condition and try again.
[task 2019-03-26T09:30:40.808Z] 09:30:40 INFO - *** Fix above errors and then restart with
[task 2019-03-26T09:30:40.808Z] 09:30:40 INFO - "./mach build"
[task 2019-03-26T09:30:40.808Z] 09:30:40 INFO - client.mk:111: recipe for target 'configure' failed
[task 2019-03-26T09:30:40.808Z] 09:30:40 INFO - make: *** [configure] Error 1
[task 2019-03-26T09:30:40.893Z] 09:30:40 ERROR - Return code: 2
[task 2019-03-26T09:30:40.893Z] 09:30:40 WARNING - setting return code to 2
[task 2019-03-26T09:30:40.894Z] 09:30:40 FATAL - 'mach build -v pre-export export recurse_rusttests' did not run successfully. Please check log for errors.
[task 2019-03-26T09:30:40.894Z] 09:30:40 FATAL - Running post_fatal callback...
[task 2019-03-26T09:30:40.894Z] 09:30:40 FATAL - Exiting -1

Clearing NI.

https://hg.mozilla.org/mozilla-central/rev/549304992d96

Hi Alex, since 67 is marked as affected, should we consider uplifting this to Beta67?

Yes, this has to go on the top of Bug 1535631.

Comment on attachment 9053397 [details]
Bug 1537725 - Use the default stack alignment in windows x86 for libdav1d. r?TD-Linux

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1533742
• User impact if declined: Crash on windows x86 with dav1d. Without it we cannot enable dav1d on beta.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1536070
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix has been verified in Nightly do some time now.
• String changes made/needed:

Comment on attachment 9053397 [details]
Bug 1537725 - Use the default stack alignment in windows x86 for libdav1d. r?TD-Linux

Crash fix, patch needed for the libdav1d update to 0.2.1 on beta. Uplift accepted for 67 beta 8, thanks.

https://hg.mozilla.org/releases/mozilla-beta/rev/47e581a4ae65