Don't access http channel in http transaction
Categories
(Core :: Networking, defect, P2)
Tracking
()
People
(Reporter: kershaw, Assigned: kershaw)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(4 files)
The reference of nsHttpChannel is directly accessed in nsHttpTransaction at [1].
The mChannel is mainly used for ActivityDistributor[2] and
[1] https://searchfox.org/mozilla-central/rev/7c20ad925005fbad7b8e08813115f1ec7fa1c248/netwerk/protocol/http/nsHttpTransaction.cpp#297
[2] https://searchfox.org/mozilla-central/rev/7c20ad925005fbad7b8e08813115f1ec7fa1c248/netwerk/protocol/http/nsHttpTransaction.cpp#1008
[3] https://searchfox.org/mozilla-central/rev/7c20ad925005fbad7b8e08813115f1ec7fa1c248/netwerk/protocol/http/nsHttpTransaction.cpp#415-434
|
||
Comment 1•6 years ago
|
||
When we land this to central, we need to rabase larch repo based on this.
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 2•6 years ago
|
||
In socket process, the reference of http channel is not accessiable. So, we use the channel id instead.
There is a table saves the mapping of channel id and the weak pointer of the channel in http handler. We use this mapping to get the real http channel.
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
|
Assignee | |
Comment 5•6 years ago
|
||
|
|
Assignee | |
Comment 6•6 years ago
|
||
https://hg.mozilla.org/projects/larch/rev/7b6dfcd73d743b88f4c57036852ec6e093c4a705
https://hg.mozilla.org/projects/larch/rev/569ea12b175bb6e4e239d8ce983d588510880a7e
https://hg.mozilla.org/projects/larch/rev/1d85eec0a8774fff22add87ae491d3eb257aa19d
https://hg.mozilla.org/projects/larch/rev/b4b9822cf7d312e55debefa59dc6b5fffbc4ca0e
Description
•