Improve column breakpoint UI performance
Categories
(DevTools :: Debugger, defect, P1)
Tracking
(firefox68 fixed)
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
(Blocks 1 open bug)
Details
(Whiteboard: [debugger-mvp][devtools-backward-compat])
Attachments
(2 files)
I noticed while profiling debugger.html that getColumnBreakpoints
takes awhile for debugger.html profile
The reason looks like getSelectedLocation, which calls isOriginalId.
STR:
- go to localhost:8000
- select debugger.js
- add some breakpoints
- reload...
Assignee | ||
Comment 1•6 years ago
|
||
Another hot spot, which comes from jryans' app is filterByUniqLocation
profile. I assume this must happen if you get a lot of breakpoint positions back.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
Another hot spot in debugger.html is findEmptyLines
profile,
- this also looks related to getSelectedLocation.
- the split takes awhile
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
After looking into this a bit, i'm seeing a couple of things:
- sending the packet of 80K locations to and from the worker is slow...
- supporting 80K locations in other UI elements is slow...
- the UI feels much snappier after the first two fixes
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Comment 7•6 years ago
|
||
bugherder |
Updated•6 years ago
|
Updated•6 years ago
|
Comment 9•6 years ago
|
||
bugherder |
Comment 10•5 years ago
|
||
When connected to an older server, the call to getBreakableLines fails:
"Action loadSourceText had an exception:"
"Protocol error (unrecognizedPacketType):
Actor server1.conn2.child9/source23 does not recognize the packet type getBreakableLines"
What can be the impact of this for a debugging session, should we address it?
Edit: discussing with Yulia, one of the possible regressions linked to this is that all lines appear greyed out as if we couldn't set breakpoints on them. Anything else?
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Description
•