Closed
Bug 1538253
Opened 6 years ago
Closed 6 years ago
VPXDecoder::IsCompatible does not compare subsampling x members correctly
Categories
(Core :: Audio/Video: Playback, defect, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla68
People
(Reporter: bryce, Assigned: bryce)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
VPXDecoder::IsCompatible appears to be using && between mSubSampling_x and aOther.mSubSampling_x where == is likely what was intended.
This will result in cases where either info does not have subsampling in the x dimension to cause the check to indicate they are incompatible, even if they are.
|
Assignee | |
Comment 1•6 years ago
|
||
We had a stray && where a == should have been.
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b0a87b6f940
VPXDecoder::IsCompatible checks subsampling x members for equality. r=jya
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
|
Assignee | |
Comment 4•6 years ago
|
||
Comment on attachment 9052903 [details]
Bug 1538253 - VPXDecoder::IsCompatible checks subsampling x members for equality. r?jya!
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: Bug 1482059
- User impact if declined: Negative performance for VP9 videos that don't use subsampling for the x dimension: we will end up recreating decoders far more often than we need to (each key frame).
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None.
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a one line patch that fixes a typo.
- String changes made/needed: None.
Attachment #9052903 -
Flags: approval-mozilla-beta?
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9052903 [details]
Bug 1538253 - VPXDecoder::IsCompatible checks subsampling x members for equality. r?jya!
Typo fix, impacts VP8 performance, uplift approved for 67 beta 6, thanks.
Attachment #9052903 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Comment 6•6 years ago
|
||
| bugherder uplift | ||
status-firefox67:
--- → fixed
|
||
Updated•6 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•