"View Saved Logins" text have no contrast with a Dark GTK Theme
Categories
(Toolkit :: Password Manager, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox66 | --- | unaffected |
firefox67 | + | verified |
firefox68 | --- | verified |
People
(Reporter: pauloeduardo2709, Assigned: sfoster)
References
Details
(Keywords: regression)
Attachments
(4 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
(deleted),
image/png
|
Details |
Hi, I'm running Linux Mint and the "View Saved Logins" text have no contrast when using a Dark GTK Theme (eg Arc Dark or Adapta Nokto). The text font colour is white and the background too.
Light Theme Screenshot (also Attached)
Dark Theme Screenshot (also Attached)
As you can see, with the Dark Theme the pane with the credential got the background colour from the GTK Theme, only the footer that render with a white background.
The Firefox Trunk version is 68.0a1 (2019-03-21) (64-bit)
.
Thank you and sorry if i did something wrong. Should I create a new issue?
Reporter | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
[Tracking Requested - why for this release]: Accessibility/aesthetic issue in new feature.
Updated•6 years ago
|
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 5•6 years ago
|
||
OK, I think I have a handle on this now. I've tested Attachment #9053011 [details] in Ubuntu with various light & dark themes, window in normal & dark mode as well as high contrast mode, and OSX.
-moz-fieldText is a system color which will (may) get changed when we change OS theme/mode. The -moz-field background color is on the containing panel. By using a translucent background color (borrowed from --arrowpanel-dimmed and --arrowpanel-dimmed-further) for the footer, we get the same relative contrast as the arrowpanel's footer as well as the selected/highlight effect as the base color is switched by the theme.
Updated•6 years ago
|
Comment 7•6 years ago
|
||
bugherder |
Updated•6 years ago
|
Comment 8•6 years ago
|
||
Can you confirm this is fixed in the latest Nightly?
Reporter | ||
Comment 9•6 years ago
|
||
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #8)
Can you confirm this is fixed in the latest Nightly?
Yes, perfect! Thank you!
Updated•6 years ago
|
Comment 10•6 years ago
|
||
Comment on attachment 9053011 [details]
Bug 1538285 - Make saved logins footer colors theme-friendly. r?MattN
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: Bug 1189618
- User impact if declined: Users on dark OS themes won't have enough contrast on the View Saved Logins autocomplete footer
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1534442
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): CSS-only change using an approach used by another part of the browser UI.
- String changes made/needed: None
Updated•6 years ago
|
Comment 11•6 years ago
|
||
Comment on attachment 9053011 [details]
Bug 1538285 - Make saved logins footer colors theme-friendly. r?MattN
Uplift approved for 67 beta 7, thanks.
Comment 12•6 years ago
|
||
bugherder uplift |
Updated•6 years ago
|
Comment 13•6 years ago
|
||
Hi, I tested this issue in Firefox 67.0b7 and the issue no longer occurs the View Saved Logins text has the proper contrast with different themes applied. I tested this issue on Ubuntu 18.04. I will mark it accordingly.
Description
•