Closed Bug 1538353 Opened 6 years ago Closed 6 years ago

Construct PBrowser with ManagedEndpoint objects

Categories

(Core :: DOM: Content Processes, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Fission Milestone M2
Tracking Status
firefox68 --- fixed

People

(Reporter: nika, Assigned: nika)

References

Details

Attachments

(2 files)

This is needed as a first step for bug 1523638.

I may not get to this until Tuesday... Will try for earlier than that, but can't guarantee it.

What is a "route"? Is there some documentation of it somewhere?

(In reply to Andrew McCreight [:mccr8] from comment #4)

What is a "route"? Is there some documentation of it somewhere?

route is another name for an actor's ID. In actor code it's usually called the actor's ID, but in the Message struct, it's called the routing_id (https://searchfox.org/mozilla-central/rev/2c912888e3b7ae4baf161d98d7a01434f31830aa/ipc/chromium/src/chrome/common/ipc_message.h#221).

I called it a route rather than an actor ID here for no particularially good reason - mostly because I was thinking in terms of lower-level routing, rather than in terms of actors. I can change it to be actorId if you'd prefer.

Flags: needinfo?(continuation)

As I said in the patch comment, I think that would be better. It explains why you were comparing a route to an actor id in the patch. Thanks.

Flags: needinfo?(continuation)
Status: NEW → ASSIGNED
Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/63de2a007d67 Part 1: Add a SetEventTargetForRoute helper to allow setting EventTargets for Endpoint-constructed actors, r=mccr8 https://hg.mozilla.org/integration/autoland/rev/654741b9c784 Part 2: Create PBrowser actors using ManagedEndpoint instead of IPDL Ctors, r=bzbarsky
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: