Closed Bug 1538366 Opened 6 years ago Closed 6 years ago

Firefox Account Avatar icon shows up on toolbar of window.open popups, unlike every other toolbar icon

Categories

(Firefox :: Firefox Accounts, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 68
Tracking Status
firefox67 --- verified
firefox68 --- verified

People

(Reporter: dholbert, Assigned: Gijs)

References

Details

Attachments

(2 files)

STR:

  1. Visit https://www.encodedna.com/javascript/demo/open-new-window-using-javascript-method.htm

  2. Click the first button, labeled "Open a new window"

ACTUAL RESULTS:
A "lightweight" popup browser-window appears, with reduced UI -- e.g. nearly all icons between URLbar and hamburger menu are gone, except for the new Sync avatar icon.

EXPECTED RESULTS:
The sync avatar icon shouldn't be present in this popup. We hide all of the other icons between the URLbar and the hamburger menu (downloads/library/sidebar/per-extension-icons), and there's no reason that the Sync icon needs special visibility to be exempt from this lighter-weight popup-window rule.

Here's a screenshot that shows the comparison between a "full" firefox window (in the background) to a lightweight popup window from window.open() in the foreground.

(I've used "customize" to add some extra icons to the toolbar, for emphasis. Note that none of these icons are visible in the popup, but the Account icon is still there, for some reason.)

Summary: Firefox Account Avatar icon shows up (alone) in window.open popups, unlike every other toolbar icon near it → Firefox Account Avatar icon shows up on toolbar of window.open popups, unlike every other toolbar icon
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/56383d31e265 don't show accounts button in popups and ensure it gets an arrow in the overflow panel, r=MattN
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

I have managed to reproduce this issue on an affected Firefox 68.0a1 (20190322164604) build using Windows 10 x64 by following the STR from comment 0.

This issue is verified fixed using Firefox 67.0b15 and Firefox 68.0a1 (20190502095227) on the following OSes: Windows 10 x64, Ubuntu 18.04 x64, Windows 7 x64, macOS 10.14.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: