Closed
Bug 1539238
Opened 5 years ago
Closed 5 years ago
Modify nsSHEntry::Create to consolidate setter calls on nsSHEntry in nsDocShell::AddToSessionHistory
Categories
(Core :: DOM: Navigation, enhancement, P2)
Tracking
()
RESOLVED
FIXED
| Fission Milestone | M2 |
People
(Reporter: annyG, Assigned: annyG)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We would like to squash these calls https://searchfox.org/mozilla-central/rev/2c912888e3b7ae4baf161d98d7a01434f31830aa/docshell/base/nsDocShell.cpp#11395-11407 into one by modifying nsSHEntry::Create signature
|
||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Fission Milestone: --- → M2
Priority: -- → P2
|
Assignee | |
Comment 1•5 years ago
|
||
nsDocShell is the only consumer of nsISHEntry::Create, and
in AddToSessionHistory method, after calling nsISHEntry::Create,
it calls 4 setter methods on nsISHEntry, which results in a
total of 5 sync IPC calls.
With the proposed solution of setting everything via
nsISHEntry::Create, we get a total of 1 sync IPC call.
|
|
||
Updated•5 years ago
|
Whiteboard: [4/25] patch r+, blocked on bug 1438272 to land
|
|
||
Updated•5 years ago
|
Whiteboard: [4/25] patch r+, blocked on bug 1438272 to land → [5/3] patch r+, waiting on try run to land
|
|
||
Comment 2•5 years ago
|
||
Pushed to ash branch:
https://hg.mozilla.org/projects/ash/rev/a8eed7c5d12c49366ad8acd706fa0e8464ed8549
Whiteboard: [5/3] patch r+, waiting on try run to land
Version: unspecified → Other Branch
|
|
||
Updated•5 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Pushed by pvanderbeken@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a1f164c082f6 Modify nsSHEntry::Create to consolidate setter calls on nsSHEntry in nsDocShell::AddToSessionHistory, r=peterv
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•