Mark JSStructuredCloneData methods MOZ_MUST_USE
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
Assignee | |
Comment 1•5 years ago
|
||
I split out the first patch because it is a little weird, so it feels like having somebody familiar with the particular code looking at it would be good.
|
|
Assignee | |
Comment 2•5 years ago
|
||
The second place doesn't return an error because that's what some
earlier code in the method does. Hopefully that is ok.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Also, fix up various places that call these methods.
Depends on D24991
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b070b6ae224 part 1 - IndexedDB changes. r=asuth https://hg.mozilla.org/integration/autoland/rev/526daf87fff9 part 2 - Mark various JSStructuredCloneData methods MOZ_MUST_USE. r=sfink
|
||
Comment 5•5 years ago
|
||
Backed out 2 changesets (bug 1539261) for multiple build bustages on /fuzz-tests/testStructuredCloneReader.cpp CLOSED TREE
Backout revision https://hg.mozilla.org/integration/autoland/rev/bf00743b877bb5848b5e7f97851813cb26c3e37b
Log failure https://treeherder.mozilla.org/logviewer.html#?job_id=236453488&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=236453494&repo=autoland
Andrew can you please take a look?
|
|
Assignee | |
Comment 6•5 years ago
|
||
Oops. Looks like SearchFox doesn't index that directory and also it doesn't build in a regular build...
|
|
Assignee | |
Comment 7•5 years ago
|
||
Steve, do you know how I can build this fuzztarget locally? I can probably grep my way to victory here but I'd rather be able to test it locally.
|
|
Assignee | |
Comment 8•5 years ago
|
||
Well, it looks like there are only those two function calls, so I'll just fix those and hope for the best.
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/054cbaead303 part 1 - IndexedDB changes. r=asuth https://hg.mozilla.org/integration/autoland/rev/ebcc9bb7c50a part 2 - Mark various JSStructuredCloneData methods MOZ_MUST_USE. r=sfink
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/054cbaead303
https://hg.mozilla.org/mozilla-central/rev/ebcc9bb7c50a
|
||
Comment 11•5 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #7)
Steve, do you know how I can build this fuzztarget locally? I can probably grep my way to victory here but I'd rather be able to test it locally.
Sorry for the delay. The simplest way would be to run js/src/devtools/automation/autospider.py fuzzing. More manually than that, you can look at js/src/devtools/automation/variants/fuzzing which gives:
{
"configure-args": "--enable-fuzzing --enable-debug-symbols='-gline-tables-only -gdwarf-2' --disable-jemalloc --disable-stdcxx-compat --enable-address-sanitizer --enable-ctypes --enable-nspr-build",
"optimize": true,
"debug": false,
"compiler": "clang",
"env": {
"JITTEST_EXTRA_ARGS": "--jitflags=none",
"JSTESTS_EXTRA_ARGS": "--jitflags=none",
"LLVM_SYMBOLIZER": "{TOOLTOOL_CHECKOUT}/clang/bin/llvm-symbolizer",
"ASAN_SYMBOLIZER_PATH": "{TOOLTOOL_CHECKOUT}/clang/bin/llvm-symbolizer"
},
"use_minidump": false
}
so hopefully running configure with those args (and --enable-optimize --disable-debug for completeness) should do it.
Description
•