Tab in auto-complete in emailing list create/edit is stuck
Categories
(Thunderbird :: Address Book, defect)
Tracking
(thunderbird_esr6067+ fixed, thunderbird67 fixed, thunderbird68 fixed)
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
aceman
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
STR:
- Open the address book
- Create a new mailing list or edit an existing one
- start typing a new member's address to autocomplete will show
a dropdown menu. Navigate down with down-arrow - Hit the tab key. Autocomplete entry is accepted,
cursor now behind the accepted entry. - Hit the tab key again. Nothing happens.
Focus should move to the next UI element, so the OK button on Windows.
This was working in TB 60.
Alice, can you find the regression for us.
In TB60, the focus moved immediately to the next button (OK on Windows, Cancel on Linux). On trunk, it stays at the end of the completed entry. That seems better behaviour. The question is why it does not move to next widget (button) on the NEXT Tab press.
|
||
Comment 2•6 years ago
|
||
Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=97c5ad955dd4cc7e162cc418af4248aff595a5ce&tochange=531dfcb2d29dcd8a6dab337faf4fd2685fcf9d40
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=09d302af0a59dadf990400f18e426766e25f21db&tochange=ddadc29de671917f66478e62a6accd4764892d25
|
Assignee | |
Comment 3•6 years ago
|
||
Thanks. You're saying we broke it in bug 1499410? But that works on the ESR now. Strange.
|
|
Assignee | |
Comment 4•6 years ago
|
||
Please don't ask why this works, but it does. It's the code we have in the ESR, see
https://hg.mozilla.org/releases/comm=esr60/rev/dd1713342fe3f723edb6da6ac8de2ed3c36d13a1
EDIT: Destroying the link so my "this needs uplift filter" works.
This isn't completely right, see bug 1536374 comment 23.
|
|
Assignee | |
Comment 6•6 years ago
|
||
Reverted the suite/ part as well, like on ESR. "Not completely right", so what do you suggest instead?
|
|
Assignee | |
Comment 7•6 years ago
|
||
Need to check param. Maybe we can bring this to a close one day ;-)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/6548cadb1648
fix tab after auto-complete in mailing list add/edit. r=aceman
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 10•6 years ago
|
||
|
|
Assignee | |
Comment 11•5 years ago
|
||
TB 60.7 ESR (or earlier, like TB 60.6.2):
https://hg.mozilla.org/releases/comm-esr60/rev/6fba52b75d2ec7bd5ac0f349be5d866ba9f5b9bd
This already worked in TB 60.6.1 but here's the last update to match trunk and avoid the JS errors in the console.
Description
•