Closed
Bug 1539687
Opened 6 years ago
Closed 6 years ago
Visual smooth scroll is incorrectly clamped to the layout scroll range
Categories
(Core :: Panning and Zooming, defect)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: botond, Assigned: botond)
References
Details
Attachments
(2 files)
While testing a patch for bug 1531531, which uses the visual smooth scrolling API added in bug 1531535, Randall discovered that the API is still clamping the visual scroll offset to the layout scroll range.
|
Assignee | |
Comment 1•6 years ago
|
||
The problem here is clamping mDestination. I thought that leave mApzSmoothScrollDestination unclamped would be sufficient, but it's not, we actually pick up mDestination as the smooth scroll destination.
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
Depends on D25176
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/152457c26513
Do not limit visual smooth scrolling to the layout scroll range. r=kats
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b6231c6dcd00
Error out if a property name is misspelt in a subtest entry. r=kats
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
|
||
Comment 8•5 years ago
|
||
(In reply to Botond Ballo [:botond] from comment #1)
I thought that leave
mApzSmoothScrollDestinationunclamped would be sufficient, but it's not
That's because the only place we actually look at the value of mApzSmoothScrollDestination is here
You need to log in
before you can comment on or make changes to this bug.
Description
•