Closed
Bug 1539726
Opened 6 years ago
Closed 5 years ago
port Bug 1539665 - Handle the tabmail-arrowscrollbox XBL logic from within tabmail-tabs (like bug 1539665 for firefox)
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 69.0
People
(Reporter: mkmelin, Assigned: aleca)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
mkmelin
:
review+
aleca
:
feedback+
|
Details | Diff | Splinter Review |
This bug is to do the corresponding changes that Firefox (will do) in bug 1539665.
This removes the tabmail-arrowscrollbox binding.
|
||
Updated•6 years ago
|
Type: enhancement → task
Summary: Bug 1539665 - Handle the tabmail-arrowscrollbox XBL logic from within tabmail-tabs (like bug 1539665 for firefox) → port Bug 1539665 - Handle the tabmail-arrowscrollbox XBL logic from within tabmail-tabs (like bug 1539665 for firefox)
|
Reporter | |
Comment 1•6 years ago
|
||
Needs to be done before bug 1514926 removes arrowscrollbox. (No patch for that yet.)
|
Assignee | |
Comment 2•5 years ago
|
||
I'm not 100% sure if what I'm doing is correct as I removed the binding and the methods, and the scrollbox works as expected.
Is this OK?
Attachment #9068789 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Updated•5 years ago
|
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 3•5 years ago
|
||
Comment on attachment 9068789 [details] [diff] [review]
tabmail-arrowscrollbox.patch
Review of attachment 9068789 [details] [diff] [review]:
-----------------------------------------------------------------
Seems to work at least for the basic functionality. I wonder if we don't need to add something like Firefox has (a initializeArrowScrollbox() call in tabmail-tabs)
|
||
Comment 4•5 years ago
|
||
The alltabs-button isn't shown with this patch.
|
|
Assignee | |
Comment 5•5 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #4)
The alltabs-button isn't shown with this patch.
Oopsie, I didn't notice that.
Apparently our alltabs-button is completely different from what's used by FF and the tabmail doesn't inherit it.
|
|
Assignee | |
Comment 6•5 years ago
|
||
Attachment #9068789 -
Attachment is obsolete: true
Attachment #9068789 -
Flags: review?(mkmelin+mozilla)
Attachment #9068875 -
Flags: review?(mkmelin+mozilla)
|
|
Reporter | |
Updated•5 years ago
|
Attachment #9068875 -
Flags: review?(mkmelin+mozilla) → review?(richard.marti)
|
|
||
Comment 7•5 years ago
|
||
Comment on attachment 9068875 [details] [diff] [review]
tabmail-arrowscrollbox.patch
Review of attachment 9068875 [details] [diff] [review]:
-----------------------------------------------------------------
This works for me.
I'll let better Magnus decide about the changes in XML.
::: mail/themes/osx/mail/tabmail.css
@@ +170,5 @@
>
> +/* Tab Overflow */
> +.tabmail-arrowscrollbox > .arrowscrollbox-overflow-start-indicator:not([collapsed]),
> +.tabmail-arrowscrollbox > .arrowscrollbox-overflow-end-indicator:not([collapsed]) {
> + margin-bottom: 0px;
0 has no unit and the px can be removed.
Attachment #9068875 -
Flags: review?(richard.marti)
Attachment #9068875 -
Flags: review?(mkmelin+mozilla)
Attachment #9068875 -
Flags: feedback+
|
|
Assignee | |
Comment 8•5 years ago
|
||
Attachment #9068875 -
Attachment is obsolete: true
Attachment #9068875 -
Flags: review?(mkmelin+mozilla)
Attachment #9069039 -
Flags: review?(mkmelin+mozilla)
Attachment #9069039 -
Flags: feedback+
|
|
Reporter | |
Comment 9•5 years ago
|
||
Comment on attachment 9069039 [details] [diff] [review]
tabmail-arrowscrollbox.patch
Review of attachment 9069039 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thx! r=mkmelin
Attachment #9069039 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed
|
||
Comment 10•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8e9201ae8281
remove tabmail-arrowscrollbox binding and handle its logic within tabmail-tabs. r=mkmelin
|
||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 69.0
You need to log in
before you can comment on or make changes to this bug.
Description
•