Closed Bug 1540731 Opened 6 years ago Closed 5 years ago

Have IPC code hold a reference to keep the actor alive

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla69

Tracking Flags:

Tracking

Status

firefox69

---

fixed

People

(Reporter: nika, Assigned: nika)

References

(Blocks 4 open bugs)

Details

Attachments

(3 files, 2 obsolete files)

Bug 1540731 - WIP 6 years ago Nika Layzell [:nika] (ni? for response) (deleted), text/x-phabricator-request		Details
Bug 1540731 - Part 1: Manage actor object lifecycles within IPC, 5 years ago Nika Layzell [:nika] (ni? for response) (deleted), text/x-phabricator-request		Details
Bug 1540731 - Part 2: Move toplevel actors to override ActorDestroy, 5 years ago Nika Layzell [:nika] (ni? for response) (deleted), text/x-phabricator-request		Details
Bug 1540731 - Part 3: Keep actors alive when calling handler methods on them, 5 years ago Nika Layzell [:nika] (ni? for response) (deleted), text/x-phabricator-request		Details
Bug 1540731 - Part 3: Stop releasing actors within ActorDestroy, 5 years ago Nika Layzell [:nika] (ni? for response) (deleted), text/x-phabricator-request		Details

Nika Layzell [:nika] (ni? for response)

Assignee

Description

•

6 years ago

This would add IPCAddRef and IPCRelease methods which control when the DeallocPProtocol method is called, and also introduce an IPCRefPtr<T> type which is used internally to manage this IPC reference count. These counts are not intended to be used outside of IPC, but rather as a temporary solution until bug 1509143 is able to be fully implemented.

Nika Layzell [:nika] (ni? for response)

Assignee

Comment 1

•

6 years ago

Attached file Bug 1540731 - WIP (obsolete) (deleted) — Details

This is an initial version of the patch for this bug, however it doesn't
successfully pass browser startup. Unfortunately, currently the browser will
crash when attempting to migrate an IPC blob actor.

Nika Layzell [:nika] (ni? for response)

Assignee

Updated

•

6 years ago

Depends on: 1540733

Nika Layzell [:nika] (ni? for response)

Assignee

Updated

•

6 years ago

No longer depends on: 1540733

Nika Layzell [:nika] (ni? for response)

Assignee

Updated

•

6 years ago

Depends on: 1540733

Nika Layzell [:nika] (ni? for response)

Assignee

•

5 years ago

Attached file Bug 1540731 - Part 3: Stop releasing actors within ActorDestroy, (deleted) — Details

Phabricator Automation

Updated

•

5 years ago

Attachment #9060262 - Attachment is obsolete: true

Phabricator Automation

Updated

•

5 years ago

Attachment #9054888 - Attachment is obsolete: true

Honza Bambas (:mayhemer)

Updated

•

5 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1550010

Nika Layzell [:nika] (ni? for response)

Assignee

Updated

•

5 years ago

Blocks: 1550560

Pulsebot

Comment 6

•

5 years ago

Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d30842e4cfea Part 1: Manage actor object lifecycles within IPC, r=froydnj https://hg.mozilla.org/integration/autoland/rev/89b214d41e50 Part 2: Move toplevel actors to override ActorDestroy, r=froydnj https://hg.mozilla.org/integration/autoland/rev/11450b71e95e Part 3: Stop releasing actors within ActorDestroy, r=mayhemer

Arthur Iakab [arthur_iakab]

Comment 7

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/d30842e4cfea
https://hg.mozilla.org/mozilla-central/rev/89b214d41e50
https://hg.mozilla.org/mozilla-central/rev/11450b71e95e

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox69: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla69

Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧

Updated

•

5 years ago

Blocks: 1562769

Nika Layzell [:nika] (ni? for response)

Assignee

Updated

•

4 years ago

Blocks: 1634761

You need to log in before you can comment on or make changes to this bug.