Chrome ui rendering sometimes broken during MotionMark test with document splitting
Categories
(Core :: Graphics: WebRender, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: sotaro, Assigned: dthayer)
References
Details
Attachments
(4 files)
Created based on Bug 1441308 Comment 84.
I tested MotionMark with pref gfx.webrender.all:true and gfx.webrender.split-render-roots:true. Rendering was sometimes broken.
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
This happens after GpuCache::clear
. We should be able to just set a flag when that's called and check it where we check resource_cache.requires_frame_build()
(in RenderBackend
).
Comment 3•6 years ago
|
||
Debian Testing, KDE, X11, Macbook Pro
Sometimes, for about 1-3 seconds, either chrome or content area are transparent and reveal what's behind Nightly's window.
I hope this bug could fix that too.
Assignee | ||
Comment 4•5 years ago
|
||
If we run a GpuCache clear and do not update all documents, we run into
situations where the stale documents try to access things in the gpu
cache and just show random garbage. The solution is similar to what we
do for TextureCache, so I am just duplicating those signatures and providing
helpers in RenderBackend to access both together.
Assignee | ||
Comment 5•5 years ago
|
||
These aren't great names - I couldn't come up with better though.
We lose the symmetry of before/after but this clarifies a little
bit what they are doing.
Depends on D29860
Assignee | ||
Comment 6•5 years ago
|
||
There's two ways we could get around this. We could add a path
around the prepared_for_frames assertion in GpuCache::end_frame,
or we can do this, and leave the TODO explicit with the
assertion. I took the latter approach because we can clear
the GpuCache / TextureCache through other routes than frame
building anyway, so we could hit this failure path before
any of the patches in this bug landed.
Depends on D29877
Updated•5 years ago
|
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/683736527e1e Require frame builds for all docs after GpuCache clear r=kvark https://hg.mozilla.org/integration/autoland/rev/d4a4c9ad62fd Rename before/after_frames r=kvark https://hg.mozilla.org/integration/autoland/rev/f53e8b390527 Add pre/post frames hooks into save_capture r=kvark
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/683736527e1e
https://hg.mozilla.org/mozilla-central/rev/d4a4c9ad62fd
https://hg.mozilla.org/mozilla-central/rev/f53e8b390527
Updated•5 years ago
|
Description
•