Closed Bug 1541222 Opened 6 years ago Closed 6 years ago

Picture-in-Picture toggle should display even if the whole video isn't fully in the viewport

Categories

(Toolkit :: Video/Audio Controls, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla68
Tracking Status
firefox68 --- verified

People

(Reporter: mconley, Assigned: mconley)

References

Details

When bug 1535354 lands, we'll be using a pretty strict guideline for when to show the toggle - namely, we'll only show it if the video is fully within the visible viewport.

jaws noted in his review for bug 1535354:

On my HiDPI display, the video stops getting the button when it is sufficiently large in YouTube's "Default view". However, if I use "Theater mode", which makes the video actually wider, then the button will appear.

So I think there's some tuning we should do here to improve the reliability of the toggle.

Blocks: 1527926
Assignee: nobody → mconley
Priority: -- → P1

This should get fixed by bug 1542756.

Depends on: 1542756

This was fixed by bug 1542756.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Build ID 20190626093633
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Verified as fixed on a HiDPI display on the latest Nightly using Windows 10.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.