Closed Bug 1541353 Opened 6 years ago Closed 5 years ago

0.57% Base Content JS (osx-10-10-shippable) regression on push 348419a9d041ee3a29d4ce5f48073003dac17f50 (Tue Apr 2 2019)

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- wontfix
firefox69 --- wontfix
firefox70 --- wontfix
firefox71 --- wontfix
firefox72 --- wontfix
firefox73 --- fixed

People

(Reporter: Bebe, Assigned: tcampbell)

References

(Regression)

Details

(Keywords: perf, perf-alert, regression, Whiteboard: [memshrink])

We have detected an awsy regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=348419a9d041ee3a29d4ce5f48073003dac17f50

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

1% Base Content JS osx-10-10-shippable opt 3,982,352.00 -> 4,005,184.00

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=20244

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/AWSY/Tests

Blocks: 1534654
Component: General → JavaScript Engine
Product: Testing → Core
Regressed by: 1530412
Version: Version 3 → unspecified
Flags: needinfo?(tcampbell)

This is occurring across all platforms. The patches in Bug 1530412 undo some complex and error-prone bitfields and move some fields to LazyScriptData. The LazyScript struct should be the same size as before, but the LazyScriptData struct grows slightly in cases when it is used. My original estimates for how often the (optional) LazyScriptData is used seem to be way off.

Ted, do you have any updates here?

Flags: needinfo?(tcampbell)

(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #2)

Ted, do you have any updates here?

Flags: needinfo?(tcampbell)
Whiteboard: [qf]

ted?

Whiteboard: [qf] → [memshrink]

This is fixed by Bug 1600705.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(tcampbell)
Resolution: --- → FIXED
Assignee: nobody → tcampbell
Target Milestone: --- → mozilla73
Depends on: 1600705
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.