Incorrect hardcoded icon colors in pocket menu (worse for dark theme)
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | verified |
People
(Reporter: Mardak, Assigned: pdahiya)
References
Details
(Keywords: github-merged)
Attachments
(2 files)
new icons in dark theme
The svgs have hardcoded colors instead of using context.
|
Reporter | |
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 2•5 years ago
|
||
Hey Punam - is this something you can knock out this week before PTO next? (if not, we'll punt it to next week and someone can grab it if they can)
|
|
Assignee | |
Comment 3•5 years ago
|
||
(In reply to Jessilyn Davis from comment #2)
Hey Punam - is this something you can knock out this week before PTO next? (if not, we'll punt it to next week and someone can grab it if they can)
PR for this bug has landed in GitHub and should get fixed in nightly in next export. Thanks!
|
|
||
Comment 4•5 years ago
|
||
Amazing! Thank you, Punam!
|
|
Reporter | |
Comment 5•5 years ago
|
||
|
||
Comment 6•5 years ago
|
||
I have verified that this issue is no longer reproducible with the latest Firefox Nightly (68.0a1 Build ID - 20190414214746) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the icons are respecting the browser's "Dark" theme colors.
|
||
Updated•5 years ago
|
Description
•