Closed Bug 1541631 Opened 6 years ago Closed 5 years ago

Move breakpoint position data/actions to be source-actor-based instead of Source-based

Tracking

(firefox70 fixed)

Status:

RESOLVED FIXED

Milestone:

Firefox 70

Tracking Flags:

Tracking

Status

firefox70

---

fixed

People

(Reporter: loganfsmyth, Assigned: loganfsmyth)

References

(Blocks 1 open bug)

Details

(Whiteboard: [debugger-mvp])

Attachments

(8 files)

Bug 1541631 - Part 1: Rename mock threadFront file to better name since it isn't a Front. r=jlast 5 years ago Logan Smyth [:loganfsmyth] (deleted), text/x-phabricator-request		Details
Bug 1541631 - Part 2: Convert Source to be a generic minimal Source interface. r=jlast 5 years ago Logan Smyth [:loganfsmyth] (deleted), text/x-phabricator-request		Details
Bug 1541631 - Part 3: Merge 'content' onto the source itself and rely on query caching. r=jlast 5 years ago Logan Smyth [:loganfsmyth] (deleted), text/x-phabricator-request		Details
Bug 1541631 - Part 4: Use resource utility for SourceWithContent caching. r=jlast 5 years ago Logan Smyth [:loganfsmyth] (deleted), text/x-phabricator-request		Details
Bug 1541631 - Part 5: Remove exitEarly option from memoizableAction since it isn't needed. r=jlast 5 years ago Logan Smyth [:loganfsmyth] (deleted), text/x-phabricator-request		Details
Bug 1541631 - Part 6: Remove unused action return values. r=jlast 5 years ago Logan Smyth [:loganfsmyth] (deleted), text/x-phabricator-request		Details
Bug 1541631 - Part 7: Convert memoizeableAction to be AsyncValue-based for easy interop. r=jlast 5 years ago Logan Smyth [:loganfsmyth] (deleted), text/x-phabricator-request		Details
Bug 1541631 - Part 8: Store breakable-line and breakpoint-position data in the source-actor store. r=jlast 5 years ago Logan Smyth [:loganfsmyth] (deleted), text/x-phabricator-request		Details

Logan Smyth [:loganfsmyth]

Assignee

Description

•

6 years ago

Because these are source-based at the moment, it is easy to forget that a Source's breakpoint positions need to be recalculated when a new source actor appears.

Logan Smyth [:loganfsmyth]

Assignee

Updated

•

6 years ago

Blocks: async-redux-improvements

Logan Smyth [:loganfsmyth]

Assignee

Updated

•

6 years ago

Priority: -- → P3

Logan Smyth [:loganfsmyth]

Assignee

Updated

•

6 years ago

Type: defect → task

Logan Smyth [:loganfsmyth]

Assignee

Updated

•

5 years ago

Blocks: dbg-70

Marco Mucci [:MarcoM]

Updated

•

5 years ago

Whiteboard: [debugger-reserve]

Marco Mucci [:MarcoM]

Updated

•

5 years ago

Whiteboard: [debugger-reserve] → [debugger-mvp]

Logan Smyth [:loganfsmyth]

Assignee

Updated

•

5 years ago

Assignee: nobody → lsmyth

Status: NEW → ASSIGNED

Logan Smyth [:loganfsmyth]

Assignee

Updated

•

5 years ago

Status: ASSIGNED → NEW

Logan Smyth [:loganfsmyth]

Assignee

Updated

•

5 years ago

Status: NEW → ASSIGNED

Logan Smyth [:loganfsmyth]

Assignee

Comment 1

•

5 years ago

Attached file Bug 1541631 - Part 1: Rename mock threadFront file to better name since it isn't a Front. r=jlast (deleted) — Details

Logan Smyth [:loganfsmyth]

Assignee

Comment 2

•

5 years ago

Attached file Bug 1541631 - Part 2: Convert Source to be a generic minimal Source interface. r=jlast (deleted) — Details

Depends on D42025

Logan Smyth [:loganfsmyth]

Assignee

Comment 3

•

5 years ago

Attached file Bug 1541631 - Part 3: Merge 'content' onto the source itself and rely on query caching. r=jlast (deleted) — Details

Depends on D42027

Logan Smyth [:loganfsmyth]

Assignee

Comment 4

•

5 years ago

Attached file Bug 1541631 - Part 4: Use resource utility for SourceWithContent caching. r=jlast (deleted) — Details

Depends on D42028

Logan Smyth [:loganfsmyth]

Assignee

Comment 5

•

5 years ago

Attached file Bug 1541631 - Part 5: Remove exitEarly option from memoizableAction since it isn't needed. r=jlast (deleted) — Details

Depends on D42029

Logan Smyth [:loganfsmyth]

Assignee

Comment 6

•

5 years ago

Attached file Bug 1541631 - Part 6: Remove unused action return values. r=jlast (deleted) — Details

Depends on D42030

Logan Smyth [:loganfsmyth]

Assignee

Comment 7

•

5 years ago

Attached file Bug 1541631 - Part 7: Convert memoizeableAction to be AsyncValue-based for easy interop. r=jlast (deleted) — Details

Depends on D42031

Logan Smyth [:loganfsmyth]

Assignee

Comment 8

•

5 years ago

Attached file Bug 1541631 - Part 8: Store breakable-line and breakpoint-position data in the source-actor store. r=jlast (deleted) — Details

Depends on D42032

Pulsebot

Comment 9

•

5 years ago

Pushed by lsmyth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/41f6c078e950 Part 1: Rename mock threadFront file to better name since it isn't a Front. r=jlast https://hg.mozilla.org/integration/autoland/rev/4f94c700f977 Part 2: Convert Source to be a generic minimal Source interface. r=jlast https://hg.mozilla.org/integration/autoland/rev/1d7a76a1fac8 Part 3: Merge 'content' onto the source itself and rely on query caching. r=jlast https://hg.mozilla.org/integration/autoland/rev/53b83b8e37e0 Part 4: Use resource utility for SourceWithContent caching. r=jlast https://hg.mozilla.org/integration/autoland/rev/9f928da98d32 Part 5: Remove exitEarly option from memoizableAction since it isn't needed. r=jlast https://hg.mozilla.org/integration/autoland/rev/6db731f26958 Part 6: Remove unused action return values. r=jlast https://hg.mozilla.org/integration/autoland/rev/696e24030686 Part 7: Convert memoizeableAction to be AsyncValue-based for easy interop. r=jlast https://hg.mozilla.org/integration/autoland/rev/bc99fb7a9d12 Part 8: Store breakable-line and breakpoint-position data in the source-actor store. r=jlast

Noemi Erli[:noemi_erli]

Comment 10

•

5 years ago

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=71dcf577d1bf86085a1751efa5446724151d42e4&revision=bc99fb7a9d125b00d33e54d002facbef7e8e3f2b&selectedJob=261874011

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261874011&repo=autoland&lineNumber=695

Backout: https://hg.mozilla.org/integration/autoland/rev/db9aaec44445e5ccfef53a25cd6812107c3df802

Flags: needinfo?(lsmyth)

Pulsebot

Comment 11

•

5 years ago

Pushed by lsmyth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a080eb120278 Part 1: Rename mock threadFront file to better name since it isn't a Front. r=jlast https://hg.mozilla.org/integration/autoland/rev/98dd6077c4d5 Part 2: Convert Source to be a generic minimal Source interface. r=jlast https://hg.mozilla.org/integration/autoland/rev/4600340598aa Part 3: Merge 'content' onto the source itself and rely on query caching. r=jlast https://hg.mozilla.org/integration/autoland/rev/c3131097b7c3 Part 4: Use resource utility for SourceWithContent caching. r=jlast https://hg.mozilla.org/integration/autoland/rev/780781260eaa Part 5: Remove exitEarly option from memoizableAction since it isn't needed. r=jlast https://hg.mozilla.org/integration/autoland/rev/1e83299913b5 Part 6: Remove unused action return values. r=jlast https://hg.mozilla.org/integration/autoland/rev/5d59b6f19e89 Part 7: Convert memoizeableAction to be AsyncValue-based for easy interop. r=jlast https://hg.mozilla.org/integration/autoland/rev/71900a2d797b Part 8: Store breakable-line and breakpoint-position data in the source-actor store. r=jlast

Logan Smyth [:loganfsmyth]

Assignee

Updated

•

5 years ago

Flags: needinfo?(lsmyth)

Cristina Coroiu [:ccoroiu]

Comment 12

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/a080eb120278
https://hg.mozilla.org/mozilla-central/rev/98dd6077c4d5
https://hg.mozilla.org/mozilla-central/rev/4600340598aa
https://hg.mozilla.org/mozilla-central/rev/c3131097b7c3
https://hg.mozilla.org/mozilla-central/rev/780781260eaa
https://hg.mozilla.org/mozilla-central/rev/1e83299913b5
https://hg.mozilla.org/mozilla-central/rev/5d59b6f19e89
https://hg.mozilla.org/mozilla-central/rev/71900a2d797b

Status: ASSIGNED → RESOLVED

Closed: 5 years ago

status-firefox70: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 70

You need to log in before you can comment on or make changes to this bug.