Closed Bug 1541910 Opened 6 years ago Closed 6 years ago

Quantumbar: popup should not have an inner border

Categories

(Firefox :: Address Bar, defect, P3)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: mehmet.sahin, Assigned: dao)

References

Details

Attachments

(3 files)

actual.png
(deleted), image/png
Details
expected.png
(deleted), image/png
Details
Bug 1541910 - Use the chrome/content separator color for the urlbar results popup's top and bottom borders consistently across platforms and remove left and right borders. r=mak
(deleted), text/x-phabricator-request
Details
Attached image actual.png (deleted) —

Firefox Nightly 68.0a1 (2019-04-04) (64-Bit)
MacOS 10.14.4 - but probably OS=ALL_Desktop

STR:

1.) Enable Quantum Bar or be in the Experiment
2.) Type something into the Address Bar
3.) Take at a look at the borders of the Drop Down, especially at the top.

Actual: The Dropdown has an inner border on all sides.

Expected: No inner border.

The Drop Down border is now (after fixing issue 1538367) aligned again with the Toolbar border, but there is an inner border which makes the border look like 2px - which looks too bold. The old Drop Down border was only 1px which looked and matched perfectly aligned with the Toolbar and window border.

Thanks for listening.

Attached image expected.png (deleted) —
Blocks: quantumbar-view, quantumbar-release
Points: --- → 1
Priority: -- → P3
Assignee: nobody → dao+bmo
Depends on: 1538367
Summary: Quantum Bar: Drop Down border should not have an inner border → Quantumbar: popup should not have an inner border
Blocks: 1543661
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cec029155339 Use the chrome/content separator color for the urlbar results popup's top and bottom borders consistently across platforms and remove left and right borders. r=mak
Iteration: --- → 68.3 - Apr 15 - 28
Iteration: 68.3 - Apr 15 - 28 → ---

https://hg.mozilla.org/mozilla-central/rev/cec029155339

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Hello Dão,

unfortunately this change brings back bug 1538367 :(

I am using a Non-Retina MacBook Air.

Should I file a new report?

Thanks.

(In reply to Mehmet from comment #5)

Hello Dão,

unfortunately this change brings back bug 1538367 :(

I am using a Non-Retina MacBook Air.

Should I file a new report?

Yep, thanks.

(In reply to Dão Gottwald [::dao] from comment #6)

(In reply to Mehmet from comment #5)

Hello Dão,

unfortunately this change brings back bug 1538367 :(

I am using a Non-Retina MacBook Air.

Should I file a new report?

Yep, thanks.

Done: Bug 1544030 :)

Blocks: 1544030
Regressions: 1544030
No longer blocks: 1544030
Regressions: 1546423
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: