Closed Bug 1542057 Opened 6 years ago Closed 4 years ago

Generate scrollinfo layers for scrollframes that contain OOP iframes

Categories

(Core :: Panning and Zooming, task, P3)

task

Tracking

()

RESOLVED FIXED
87 Branch
Fission Milestone M7
Tracking Status
firefox87 --- fixed

People

(Reporter: kats, Assigned: hiro)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [apz:fission:8:S])

Attachments

(2 files)

For fission, we might have an unscrollable OOP iframe inside an inactive scrollframe in the parent document. The hit-test would target the OOP iframe's root scrollframe, and APZ would be responsible for handing off any scroll attempts on that to the enclosing scrollframe. If the enclosing scrollframe is inactive, APZ might not even really know about it, and hand off to the wrong thing.

So when building the display list we should make sure to add metrics for inactive scrollframes that contain OOP iframes, so that APZ knows the right handoff target. That scrollframe doesn't need to be activated though; we can activate it lazily from the repaint request after APZ tries to scroll it. This scenario presumably won't get hit often enough to warrant the memory hit from activating the scrollframe.

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → ?
Fission Milestone: ? → M6
Fission Milestone: M6 → M7
Whiteboard: [apz:fission:8:S]

Botond, is this still broken?

Flags: needinfo?(botond)

Yes, this is still an issue. I plan to look at this as part of the M7 APZ work after work on M6c issues wraps up.

Flags: needinfo?(botond)

I'm going to keep this as an M7 because it only affects scroll handoff, i.e. it doesn't actually prevent you from scrolling or interacting with anything (except perhaps in a pathological case of a scrollable subframe whose viewport is taken up entirely by an OOP iframe).

I am going to use this bug to add a (at least one) test for this issue, this issue itself has been fixed by bug 1675547 I assume.

Assignee: nobody → hikezoe.birchill
Status: NEW → ASSIGNED
Pushed by hikezoe.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/73824cc3c66a Drop redundant </head>s. r=botond https://hg.mozilla.org/integration/autoland/rev/81bec1bb5b4e A test that wheel events on an unscrollable OOP iframe are handoff-ed properly. r=botond
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: