Closed Bug 1542240 Opened 6 years ago Closed 6 years ago

Move Engine and EngineURL objects to their own .jsm files.

Categories

(Firefox :: Search, task)

Product:
Firefox
Component:
Search
Type:
task
Priority:
Not set
Severity:
normal
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Iteration:
68.4 - Apr 29 - May 12
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

Bug 1542240 - Move Engine and EngineURL into their own .jsm to help simplify maintaining the search service. r?daleharvey,mikedeboer
(deleted), text/x-phabricator-request
Details
Bug 1542240 - Various cleanups to the search service and engines following separation. r?daleharvey,mikedeboer
(deleted), text/x-phabricator-request
Details

SearchService.jsm is currently very big and complex. The actual SearchService doesn't start until over half way down the 4500 line file.

There's no particular reason why Engine and EngineURL must be in the same file, so we think it would be better to split those out to their own file and then the various components of the search service would be easier to find.

It will also likely help separate out the various helper functions and constants.

Blocks: search-modernization
No longer regressed by: search-modernization
Summary: Move Engine and EngineURL objects to their own .jsm files. → [meta] Move Engine and EngineURL objects to their own .jsm files.
Keywords: meta
Summary: [meta] Move Engine and EngineURL objects to their own .jsm files. → Move Engine and EngineURL objects to their own .jsm files.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e704a59c9da6 Move Engine and EngineURL into their own .jsm to help simplify maintaining the search service. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/e53475bc9b50 Various cleanups to the search service and engines following separation. r=daleharvey

https://hg.mozilla.org/mozilla-central/rev/e704a59c9da6
https://hg.mozilla.org/mozilla-central/rev/e53475bc9b50

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Depends on: 1550599
Blocks: 1550599
No longer depends on: 1550599
Iteration: --- → 68.4 - Apr 29 - May 12
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: