processFileChanges shouldn't be called for builtin location
Categories
(Toolkit :: Add-ons Manager, defect, P3)
Tracking
()
People
(Reporter: mixedpuppy, Unassigned)
Details
see https://phabricator.services.mozilla.com/D25244#772041
sourceBundle is undefined or null.
Reporter | ||
Comment 1•6 years ago
|
||
suggestion from aswan:
untested, but something like this as the first line inside the "for (let location of ...)" loop
if (!location.enumerable) { continue; }
Dale, can you give that a spin in your patch and see if that addresses the issue?
Comment 2•6 years ago
|
||
Hey, gave that a shot but nope, test hangs if I delete my sourceBundle check and add that line
Reporter | ||
Comment 3•6 years ago
|
||
:aswan thoughts? Need to figure this out tomorrow so we can get something to unblock landing the search patches.
Reporter | ||
Comment 4•6 years ago
|
||
:daleharvey says "and 1542383 seems maybe fixed, I took the fix out and havent seen that stack"
I'll keep this open a bit longer, but removing it as blocking.
Comment 5•6 years ago
|
||
(In reply to Shane Caraveo (:mixedpuppy) from comment #3)
:aswan thoughts? Need to figure this out tomorrow so we can get something to unblock landing the search patches.
how can i reproduce this? pull all the bug 1496075 patches and run locally?
Updated•4 years ago
|
Description
•