Open Bug 1542468 Opened 6 years ago Updated 2 years ago

Check if forceOwnRefreshDriver is still needed on DevTools iframes

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: jdescottes, Unassigned)

References

Details

The forceOwnRefreshDriver attribute is only used by devtools iframes:

This attribute was added in Bug 832920 to avoid a Windows-only graphical glitch: CSS transitions would stop working after swapping from a docked host to a separate window host.

Setting the attribute on the iframe avoids running

  if (!containingElement->IsXULElement() ||
      !containingElement->HasAttr(kNameSpaceID_None,
                                  nsGkAtoms::forceOwnRefreshDriver)) {
    mRefreshDriver = parent->GetPresContext()->RefreshDriver();
  }

searchfox

which will then force:

if (!mRefreshDriver) {
  mRefreshDriver = new nsRefreshDriver(this);
  if (XRE_IsContentProcess()) {
    mRefreshDriver->InitializeTimer();
  }
}

We should check if the bug is still valid and if we should keep the attribute.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.