Add more temporary logging to LocalStorageShutdownTimeout crash annotation
Categories
(Core :: Storage: localStorage & sessionStorage, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | affected |
People
(Reporter: janv, Assigned: janv)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/plain
|
chutten
:
data-review+
|
Details |
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
I'd like to add more logging which would iterate over the global arrays / hashtables and collect persistence types, origin strings and maybe some additional stuff.
We need this info only for short period of time to get an idea what type of LocalStorage is causing this.
So we would be able to focus on exact areas in the code.
Anyway, I'll wait for UnsafePtr (bug 1539538) to see if that reveals something.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Andrew, do you think we don't need this anymore ?
Comment 4•5 years ago
|
||
Not sure. Apologies, I reviewed this the other day but didn't hit submit and it got lost in my sea of tabs :(. (I now have a thing to help with that though. :)
If you think we need it, you should land it.
Assignee | ||
Comment 5•5 years ago
|
||
Yes, we should land this patch. I think the shutdown hangs are now greatly reduced, but not 100% fixed yet.
Assignee | ||
Comment 6•5 years ago
|
||
This data review request is very similar to bug 1542478.
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
Comment 9•5 years ago
|
||
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
bugherder |
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Description
•