Closed Bug 1543122 Opened 6 years ago Closed 6 years ago

Add the Picture-in-Picture toggle to the <video controls/> UAWidget binding

Categories

(Toolkit :: Video/Audio Controls, enhancement, P1)

Product:
Toolkit
Component:
Video/Audio Controls
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(5 files)

Bug 1543122 - Allow passing a static list of preference values to UAWidgets upon construction. r?bgrins
(deleted), text/x-phabricator-request
Details
Bug 1543122 - Add a preference for controlling whether or not we display a toggle for Picture-in-Picture on <video> elements. r?jaws
(deleted), text/x-phabricator-request
Details
Bug 1543122 - Add a privileged UAWidget-accessible WebIDL API for triggering Picture-in-Picture. r?jya,ehsan
(deleted), text/x-phabricator-request
Details
Bug 1543122 - Add the simple Picture-in-Picture toggle to the <video controls/> binding, still preffed off by default. r?jaws
(deleted), text/x-phabricator-request
Details
one-liner-fix.diff
(deleted), patch
Details | Diff | Splinter Review

This will require the following:

  1. The ability for the UAWidget to know whether or not the preference to show the toggle is enabled

  2. The ability for the UAWidget to launch Picture-in-Picture when the user clicks on that toggle (likely via a WebIDL method on HTMLVideoElement, since the events dispatched directly from the UAWidget scope don't seem to be trusted)

  3. Adjust the PictureInPictureToggleChild to not show the AnonymousContent toggle or flyout toggle over top of <video controls/> elements

Assignee: nobody → mconley
Priority: -- → P1
Blocks: 1543128
Type: defect → enhancement

This also stops the PictureInPictureToggleChild from tracking videos with controls for now.

Depends on D26777

Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aab68db4131b Allow passing a static list of preference values to UAWidgets upon construction. r=bgrins https://hg.mozilla.org/integration/autoland/rev/3fce0b7586c1 Add a preference for controlling whether or not we display a toggle for Picture-in-Picture on <video> elements. r=jaws https://hg.mozilla.org/integration/autoland/rev/1645d577016c Add a privileged UAWidget-accessible WebIDL API for triggering Picture-in-Picture. r=jya,Ehsan https://hg.mozilla.org/integration/autoland/rev/20092bcebe6a Add the simple Picture-in-Picture toggle to the <video controls/> binding, still preffed off by default. r=jaws
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3619626a7662 Allow passing a static list of preference values to UAWidgets upon construction. r=bgrins https://hg.mozilla.org/integration/autoland/rev/22f9a15468c4 Add a preference for controlling whether or not we display a toggle for Picture-in-Picture on <video> elements. r=jaws https://hg.mozilla.org/integration/autoland/rev/fbb2191cafbe Add a privileged UAWidget-accessible WebIDL API for triggering Picture-in-Picture. r=jya,Ehsan https://hg.mozilla.org/integration/autoland/rev/bd9017823675 Add the simple Picture-in-Picture toggle to the <video controls/> binding, still preffed off by default. r=jaws
Attached patch one-liner-fix.diff (deleted) — — Splinter Review

Bah, this will teach me to "clean up a patch" after pushing to try. :( (This is to fix the TV failure on the most recent push).

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: