Closed Bug 1543245 Opened 6 years ago Closed 6 years ago

Use prototype document content sink for all chrome privileged XHTML

Categories

(Firefox :: General, defect, P1)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: bdahl, Assigned: bdahl)

References

Details

Attachments

(2 files)

Bug 1543245 - Use prototype document for all chrome XHTML pages. r=smaug
(deleted), text/x-phabricator-request
Details
Bug 1543245 - Prevent HTML script tags from loading twice when using PrototypeDocument. r=smaug
(deleted), text/x-phabricator-request
Details

Let all chrome privileged XHTML take advantage of the cache and faster document creation with the prototype document.

Let all chrome privileged XHTML take advantage of the cache and
faster document creation with the prototype document.

HTML script tags were being loaded once by the element when it was bound
to the tree and a second time by the PrototypeDocumentContentSink. This
patch disables the script element from loading itself.

Depends on D26822

Pushed by bdahl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a4d256528051 Use prototype document for all chrome XHTML pages. r=smaug https://hg.mozilla.org/integration/autoland/rev/8e8da015fde1 Prevent HTML script tags from loading twice when using PrototypeDocument. r=smaug

https://hg.mozilla.org/mozilla-central/rev/a4d256528051
https://hg.mozilla.org/mozilla-central/rev/8e8da015fde1

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Backed out for frequently failing devtools at devtools/client/inspector/test/browser_inspector_highlighter-07.js

Backout: https://hg.mozilla.org/integration/autoland/rev/b8a94f3e338faf034912fda7532df0a96ceafdac

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cshippable%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-windows10-64-shippable%2Fopt-mochitest-devtools-chrome-e10s-7%2Cm-e10s%28dt7%29&revision=8e8da015fde18e4068f22f7f137ec9899b4310c8

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239543352&repo=autoland&lineNumber=2888

02:00:26 INFO - TEST-OK | devtools/client/inspector/test/browser_inspector_highlighter-06.js | took 2136ms
02:00:26 INFO - checking window state
02:00:26 INFO - TEST-START | devtools/client/inspector/test/browser_inspector_highlighter-07.js
02:00:27 INFO - GECKO(3876) | [ACTION] SET_WORKERS - {"type":"SET_WORKERS","cx":{"navigateCounter":0},"workers":[],"mainThread":"server1.conn24.child1/context18"}
02:00:27 INFO - GECKO(3876) | [ACTION] CONNECT - {"type":"CONNECT","mainThread":{"url":"data:text/html;charset=utf-8,<style>iframe {height:200px;border: 11px solid black;padding: 13px;}body,iframe {margin:0}</style><body><script>setInterval('debugger', 100)</script><iframe src='data:text/html;charset=utf-8,<style>body {margin:0;height:100%;background-color:red}</style><body>hello from iframe</body>'></iframe></body>","actor":"server1.conn24.child1/context18","type":-1},"canRewind":false}
02:00:27 INFO - GECKO(3876) | [ACTION] ADD_SOURCES - {"type":"ADD_SOURCES","cx":{"navigateCounter":0},"sources":[{"id":"sourceURL-data:text/html;charset=utf-8,<style>iframe {height:200px;border: 11px solid black;padding: 13px;}body,iframe {margin:0}</style><body><script>setInterval('debugger', 100)</script><iframe src='data:text/html;charset=utf-8,<style>body {margin:0;height:100%;background-color:red}</style><body>hello from iframe</body>'></iframe></body>","url":"","relativeUrl":"data:text/html;charset=utf-8,<style>iframe {height:200px;border: 11px solid black;padding: 13px;}body,iframe {margin:0}</style><body><script>setInterval('debugger', 100)</script><iframe src='data:text/html;charset=utf-8,<style>body {margin:0;height:100%;background-color:red}</style><body>hello from iframe</body>'></iframe></body>","isPrettyPrinted":false,"sourceMapURL":null,"introductionUrl":null,"isBlackBoxed":false,"loadedState":"unloaded","isWasm":false,"isExtension":false,"actors":[{"actor":"server1.conn24.child1/source20","source":"sourceURL-data:text/html;charset=utf-8,<style>iframe {height:200px;border: 11px solid black;padding: 13px;}body,iframe {margin:0}</style><body><script>setInterval('debugger', 100)</script><iframe src='data:text/html;charset=utf-8,<style>body {margin:0;height:100%;background-color:red}</style><body>hello from iframe</body>'></iframe></body>","thread":"server1.conn24.child1/context18"}]},{"id":"sourceURL-data:text/html;charset=utf-8,<style>iframe {height:200px;border: 11px solid black;padding: 13px;}body,iframe {margin:0}</style><body><script>setInterval('debugger', 100)</script><iframe src='data:text/html;charset=utf-8,<style>body {margin:0;height:100%;background-color:red}</style><body>hello from iframe</body>'></iframe></body>","url":"","relativeUrl":"data:text/html;charset=utf-8,<style>iframe {height:200px;border: 11px solid black;padding: 13px;}body,iframe {margin:0}</style><body><script>setInterval('debugger', 100)</script><iframe src='data:text/html;charset=utf-8,<style>body {margin:0;height:100%;background-color:red}</style><body>hello from iframe</body>'></iframe></body>","isPrettyPrinted":false,"sourceMapURL":null,"introductionUrl":null,"introductionType":"scriptElement","isBlackBoxed":false,"loadedState":"unloaded","isWasm":false,"isExtension":false,"actors":[{"actor":"server1.conn24.child1/source40","source":"sourceURL-data:text/html;charset=utf-8,<style>iframe {height:200px;border: 11px solid black;padding: 13px;}body,iframe {margin:0}</style><body><script>setInterval('debugger', 100)</script><iframe src='data:text/html;charset=utf-8,<style>body {margin:0;height:100%;background-color:red}</style><body>hello from iframe</body>'></iframe></body>","thread":"server1.conn24.child1/context18"}]}]}
02:00:27 INFO - TEST-INFO | started process screenshot
02:00:27 INFO - TEST-INFO | screenshot: exit 0
02:00:27 INFO - Buffered messages logged at 02:00:26
02:00:27 INFO - Entering test bound
02:00:27 INFO - Adding a new tab with URL: data:text/html;charset=utf-8,<style>iframe {height:200px;border: 11px solid black;padding: 13px;}body,iframe {margin:0}</style><body><script>setInterval('debugger', 100)</script><iframe src='data:text/html;charset=utf-8,<style>body {margin:0;height:100%;background-color:red}</style><body>hello from iframe</body>'></iframe></body>
02:00:27 INFO - Tab added and finished loading
02:00:27 INFO - Opening the inspector
02:00:27 INFO - Opening the toolbox
02:00:27 INFO - Buffered messages logged at 02:00:27
02:00:27 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/Breakpoint.js" line: 29}]
02:00:27 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/Breakpoint.js" line: 29}]
02:00:27 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/Breakpoint.js" line: 29}]
02:00:27 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/Breakpoint.js" line: 29}]
02:00:27 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/ColumnBreakpoint.js" line: 26}]
02:00:27 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/ColumnBreakpoint.js" line: 26}]
02:00:27 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/ColumnBreakpoint.js" line: 26}]
02:00:27 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/ColumnBreakpoint.js" line: 26}]
02:00:27 INFO - must wait for focus
02:00:27 INFO - Toolbox opened and focused
02:00:27 INFO - Buffered messages finished
02:00:27 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_highlighter-07.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_highlighter-07.js:34 - TypeError: panel is undefined
02:00:27 INFO - Stack trace:
02:00:27 INFO - createDebuggerContext@chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_highlighter-07.js:34:15
02:00:27 INFO - @chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_highlighter-07.js:79:15
02:00:27 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1116:34
02:00:27 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1144:12
02:00:27 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1005:14
02:00:27 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
02:00:27 INFO - Leaving test bound
02:00:27 INFO - GECKO(3876) | [ACTION] PAUSED - {"type":"PAUSED","thread":"server1.conn24.child1/context18","why":{"type":"debuggerStatement"},"frames":[{"id":"server1.conn24.child1/frame22","location":{"sourceId":"sourceURL-data:text/html;charset=utf-8,<style>iframe {height:200px;border: 11px solid black;padding: 13px;}body,iframe {margin:0}</style><body><script>setInterval('debugger', 100)</script><iframe src='data:text/html;charset=utf-8,<style>body {margin:0;height:100%;background-color:red}</style><body>hello from iframe</body>'></iframe></body>","line":1,"column":0},"displayName":"(global)"}],"selectedFrameId":"server1.conn24.child1/frame22","loadedObjects":[],"pauseInfo":{"why":{"type":"debuggerStatement"}},"scopes":[]}
02:00:27 INFO - GECKO(3876) | [ACTION] SET_EXPANDED_STATE - {"type":"SET_EXPANDED_STATE","thread":"server1.conn24.child1/context18","expanded":{}}
02:00:27 INFO - GECKO(3876) | [ACTION] SET_ORIENTATION - {"type":"SET_ORIENTATION","orientation":"horizontal"}
02:00:27 INFO - GECKO(3876) | console.warn: "Error while detaching the thread front: 'detach' request packet to 'server1.conn24.child1/context18' can't be sent as the connection is closed."
02:00:27 INFO - Removing tab.
02:00:27 INFO - Waiting for event: 'TabClose' on [object XULElement].
02:00:27 INFO - Got event: 'TabClose' on [object XULElement].
02:00:27 INFO - Tab removed and finished closing
02:00:27 INFO - GECKO(3876) | MEMORY STAT | vsize 2103195MB | vsizeMaxContiguous 65429712MB | residentFast 339MB | heapAllocated 135MB

Status: RESOLVED → REOPENED
status-firefox68: fixed → ---
Flags: needinfo?(bdahl)
Resolution: FIXED → ---
Target Milestone: Firefox 68 → ---

(Setting this to P1 just since it's actively being worked on)

Priority: -- → P1
Pushed by bdahl@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/30a83af0933c Use prototype document for all chrome XHTML pages. r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/51d1ead01c87 Prevent HTML script tags from loading twice when using PrototypeDocument. r=smaug

https://hg.mozilla.org/mozilla-central/rev/30a83af0933c
https://hg.mozilla.org/mozilla-central/rev/51d1ead01c87

Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Flags: needinfo?(bdahl)
Regressions: 1545957
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: