Closed Bug 1543538 Opened 5 years ago Closed 5 years ago

Perma TV browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js | newtab private permission after permission change - Got true, expected false

Categories

(WebExtensions :: Untriaged, defect, P1)

Product:
WebExtensions
Component:
Untriaged
Type:
defect

Tracking

(firefox-esr60 unaffected, firefox66 unaffected, firefox67 unaffected, firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mixedpuppy)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1543538 fix TV failure in browser_ext_tabs_newtab_private.js due to async test
(deleted), text/x-phabricator-request
Details

#[markdown(off)]
Filed by: dvarga [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=239490779&repo=mozilla-central

https://queue.taskcluster.net/v1/task/XHIK72W1QbqOJS_KF3-29g/runs/0/artifacts/public/logs/live_backing.log

[task 2019-04-10T23:05:21.633Z] 23:05:21 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js | newtab extension controlled -
[task 2019-04-10T23:05:21.633Z] 23:05:21 INFO - Buffered messages finished
[task 2019-04-10T23:05:21.635Z] 23:05:21 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js | newtab private permission after permission change - Got true, expected false
[task 2019-04-10T23:05:21.636Z] 23:05:21 INFO - Stack trace:
[task 2019-04-10T23:05:21.636Z] 23:05:21 INFO - chrome://mochikit/content/browser-test.js:test_is:1325
[task 2019-04-10T23:05:21.637Z] 23:05:21 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js:verifyPrefSettings:21
[task 2019-04-10T23:05:21.637Z] 23:05:21 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js:test_new_tab_private:74
[task 2019-04-10T23:05:21.638Z] 23:05:21 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T23:05:21.639Z] 23:05:21 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T23:05:21.640Z] 23:05:21 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1000
[task 2019-04-10T23:05:21.640Z] 23:05:21 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T23:05:21.644Z] 23:05:21 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js | Newtab url is overridden by the extension. -
[task 2019-04-10T23:05:21.645Z] 23:05:21 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T23:05:21.646Z] 23:05:21 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js | active newtab url is default. - Got moz-extension://000f35c2-fd52-4077-affb-51ec951c944c/webext-newtab-1.html, expected about:privatebrowsing
[task 2019-04-10T23:05:21.647Z] 23:05:21 INFO - Stack trace:
[task 2019-04-10T23:05:21.647Z] 23:05:21 INFO - chrome://mochikit/content/browser-test.js:test_is:1325
[task 2019-04-10T23:05:21.648Z] 23:05:21 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js:verifyPrefSettings:30
[task 2019-04-10T23:05:21.649Z] 23:05:21 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js:test_new_tab_private:74
[task 2019-04-10T23:05:21.649Z] 23:05:21 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T23:05:21.650Z] 23:05:21 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T23:05:21.650Z] 23:05:21 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1000
[task 2019-04-10T23:05:21.651Z] 23:05:21 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T23:05:21.653Z] 23:05:21 INFO - update private allowed permission
[task 2019-04-10T23:05:21.654Z] 23:05:21 INFO - GECKO(7781) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-04-10T23:05:21.655Z] 23:05:21 INFO - GECKO(7781) | [Parent 7781, Main Thread] WARNING: '!parent', file /builds/worker/workspace/build/src/netwerk/ipc/NeckoParent.cpp, line 955
[task 2019-04-10T23:05:21.660Z] 23:05:21 INFO - GECKO(7781) | JavaScript error: chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js, line 20: ReferenceError: is is not defined
[task 2019-04-10T23:05:21.661Z] 23:05:21 INFO - Console message: [JavaScript Error: "ReferenceError: is is not defined" {file: "chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js" line: 20}]
[task 2019-04-10T23:05:21.662Z] 23:05:21 INFO - GECKO(7781) | [Parent 7781, QuotaManager IO] WARNING: 'NS_FAILED(directory->GetDirectoryEntries(getter_AddRefs(entries)))', file /builds/worker/workspace/build/src/dom/quota/ActorsParent.cpp, line 7612
[task 2019-04-10T23:05:21.666Z] 23:05:21 INFO - GECKO(7781) | [Parent 7781, QuotaManager IO] WARNING: 'NS_FAILED(directory->GetDirectoryEntries(getter_AddRefs(entries)))', file /builds/worker/workspace/build/src/dom/quota/ActorsParent.cpp, line 7612
[task 2019-04-10T23:05:21.666Z] 23:05:21 INFO - GECKO(7781) | [Parent 7781, QuotaManager IO] WARNING: 'NS_FAILED(directory->GetDirectoryEntries(getter_AddRefs(entries)))', file /builds/worker/workspace/build/src/dom/quota/ActorsParent.cpp, line 7612
[task 2019-04-10T23:05:21.667Z] 23:05:21 INFO - GECKO(7781) | [Parent 7781, QuotaManager IO] WARNING: 'NS_FAILED(directory->GetDirectoryEntries(getter_AddRefs(entries)))', file /builds/worker/workspace/build/src/dom/quota/ActorsParent.cpp, line 7612
[task 2019-04-10T23:05:21.671Z] 23:05:21 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T23:05:21.676Z] 23:05:21 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js | A promise chain failed to handle a rejection: is is not defined - stack: verifyPrefSettings@chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js:20:3

Summary: Intermittent browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js | newtab private permission after permission change - Got true, expected false → Perma TV browser/components/extensions/test/browser/browser_ext_tabs_newtab_private.js | newtab private permission after permission change - Got true, expected false
Flags: needinfo?(mixedpuppy)

This is a simple fix, patch coming.

Flags: needinfo?(mixedpuppy)
Blocks: 1532165
Priority: P5 → P1
Assignee: nobody → mixedpuppy
Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99bbdc8f9913
fix TV failure in browser_ext_tabs_newtab_private.js due to async test r=kmag

https://hg.mozilla.org/mozilla-central/rev/99bbdc8f9913

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

From my understanding this issue is related to the automated tests. Is there any need of manual QA here? If not can you please mark it as "qe-verify- "

Flags: needinfo?(mixedpuppy)
Flags: needinfo?(mixedpuppy) → qe-verify-
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: