Links to worker sources in the debugger do not work for terminated workers
Categories
(DevTools :: Console, defect, P3)
Tracking
(firefox68 fixed)
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
(Blocks 1 open bug)
Details
(Whiteboard: [debugger-mvp])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
When a console message refers to something that happened in a worker thread, any links to source locations for that message do not work. The debugger opens but shows a message like 'Error loading this URI: No such actor for ID: server1.conn0.child1/workerTarget38/source4'
Assignee | ||
Comment 1•6 years ago
|
||
On closer inspection, this only happens when the clicking on a link for a message from a worker that has terminated.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 2•6 years ago
|
||
we should have a mechanism to handle location that are no longer relevant.
We kind of have the same case when the "Persist Logs" is checked and you navigate to another page: the location of the messages from the previous page are still clickable, which might cause weird results.
Assignee | ||
Updated•6 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/60085ea6ff72 Don't view sources that can't be loaded in the debugger, r=loganfsmyth.
Comment 5•5 years ago
|
||
Backed out for causing perma failures.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246247394&repo=mozilla-inbound&lineNumber=293
[task 2019-05-14T00:13:52.941Z] TEST START | Flow
[task 2019-05-14T00:14:07.236Z] Error ----------------------------------------------------------------------------------- src/reducers/sources.js:903:43
[task 2019-05-14T00:14:07.236Z]
[task 2019-05-14T00:14:07.236Z] Cannot call getSourceActorsForSource
with state
bound to state
because property sourceActors
is missing in
[task 2019-05-14T00:14:07.236Z] OuterState
[1] but exists in SourceActorOuterState
[2].
[task 2019-05-14T00:14:07.236Z]
[task 2019-05-14T00:14:07.236Z] src/reducers/sources.js:903:43
[task 2019-05-14T00:14:07.236Z] 903| const actors = getSourceActorsForSource(state, sourceId);
[task 2019-05-14T00:14:07.236Z] ^^^^^
[task 2019-05-14T00:14:07.236Z]
[task 2019-05-14T00:14:07.236Z] References:
[task 2019-05-14T00:14:07.236Z] src/reducers/sources.js:891:38
[task 2019-05-14T00:14:07.236Z] 891| export function canLoadSource(state: OuterState, sourceId: string) {
[task 2019-05-14T00:14:07.236Z] ^^^^^^^^^^ [1]
[task 2019-05-14T00:14:07.236Z] src/reducers/sources.js:880:23
[task 2019-05-14T00:14:07.236Z] 880| state: OuterState & SourceActorOuterState,
[task 2019-05-14T00:14:07.236Z] ^^^^^^^^^^^^^^^^^^^^^ [2]
[task 2019-05-14T00:14:07.236Z]
[task 2019-05-14T00:14:07.236Z]
[task 2019-05-14T00:14:07.236Z]
[task 2019-05-14T00:14:07.236Z] Found 1 error
[task 2019-05-14T00:14:07.236Z]
[task 2019-05-14T00:14:21.628Z] TEST-UNEXPECTED-FAIL | Cannot call getSourceActorsForSource
with state
bound to state
because property sourceActors
is missing in OuterState
[1] but exists in SourceActorOuterState
[2].
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/22a3a17e5a419109cb17d83d1803ae652145b6a7
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/846d0d928675 Don't view sources that can't be loaded in the debugger, r=loganfsmyth.
Comment 7•5 years ago
|
||
bugherder |
Assignee | ||
Updated•5 years ago
|
Description
•