Closed Bug 1543844 Opened 6 years ago Closed 6 years ago

Fix incorrect max scale detection in WR border rendering.

Categories

(Core :: Graphics: WebRender, defect, P2)

Product:
Core
Component:
Graphics: WebRender
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox-esr60 --- disabled
firefox66 --- disabled
firefox67 --- fixed
firefox68 --- fixed

People

(Reporter: gw, Assigned: gw)

References

Details

(Keywords: crash)

Attachments

(1 file)

Bug 1543844 - Fix incorrect max scale detection in WR border rendering.
(deleted), text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details
No description provided.
Assignee: nobody → gwatson

The local rect for border segments is not solely determined by
the widths and/or radius. Instead of determining the max scale
based on those parameters, use the calculated border segment
rects to determine an appropriate max scale factor.

Blocks: wr-67
Priority: -- → P2
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b1b702b25f53 Fix incorrect max scale detection in WR border rendering. r=emilio

https://hg.mozilla.org/mozilla-central/rev/b1b702b25f53

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Comment on attachment 9057716 [details]
Bug 1543844 - Fix incorrect max scale detection in WR border rendering.

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1519833
  • User impact if declined: WebRender crashes on sites that have borders with extremely large scale transforms.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Only affects users enrolled in WebRender, which is nVidia desktop + Win10. The patch is reasonably simple, and fixes crashes in these cases.
  • String changes made/needed:
Attachment #9057716 - Flags: approval-mozilla-beta?
No longer blocks: 1519833
status-firefox-esr60: --- → disabled
Keywords: crash
Regressed by: 1519833

Comment on attachment 9057716 [details]
Bug 1543844 - Fix incorrect max scale detection in WR border rendering.

Fix for a Webrender crash, we ship Webrender v1 in 67, uplift approved for 67 beta 11, thanks.

Attachment #9057716 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Blocks: 1519833
No longer regressed by: 1519833
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: