Refactor treeOrder.js in sources-tree for readability & remove duplicate code
Categories
(DevTools :: Debugger, task, P3)
Tracking
(firefox69 fixed)
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: anthonyxie64, Assigned: anthonyxie64)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Within treeOrder.js, the file responsible for sorting the sourcesTree, we have a matcher function for each exception (index, debuggeeHost, etc.) because we want to account for these edge cases when sorting the sourcesTree.
We have duplicate code for each of these matcher functions and going forward, adding more edge cases will only result in more duplicate code and impact readability.
Assignee | ||
Comment 1•6 years ago
|
||
Given you find this is a valid issue, I'd like to work on it!
Assignee | ||
Updated•6 years ago
|
Comment 2•6 years ago
|
||
Go for it!
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 4•6 years ago
|
||
Hey Jason, thanks for checking in. I wanted to wait until Bug #1533418 was resolved before working on this. I've also been busy applying to jobs recently, will revisit this next week! But if someone wants to work on this in the meantime, happy to share what I've done so far and pair on the issue :)
Comment 5•6 years ago
|
||
Refactored treeOrder code to remove duplicate code and make it simple to add
new exceptions in sorting the sourcesTree
Comment 7•5 years ago
|
||
bugherder |
Description
•