Closed
Bug 1544026
Opened 6 years ago
Closed 6 years ago
Tabs in "Certificate Manager" are unreadable in dark-mode
Categories
(Firefox :: Theme, defect, P3)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: Paenglab, Assigned: Paenglab)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-68b-p2])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In dark-mode the tabs in "Certificate Manager" are unreadable because they don't change the colour in dark-mode.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
Blocks: dark-incontent-pages
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
|
||
Comment 2•6 years ago
|
||
Revision is blocked from landing due to missing author information
Flags: needinfo?(richard.marti)
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•6 years ago
|
||
How do I set the author? Phab says "Authored by Paenglab".
Flags: needinfo?(richard.marti)
|
|
||
Comment 4•6 years ago
|
||
Flags: needinfo?(richard.marti)
|
|
Assignee | |
Comment 5•6 years ago
|
||
I created the patch via the Phabricator Web UI. I don't want to install all this peaces on Windows as this is too complicated for the 2-3 patches I create for M-C in a year.
Why does the Web UI creation exists when it's not useful for the workflow?
The same will happen with bug 1544025 when it has r+.
Flags: needinfo?(richard.marti)
|
|
||
Updated•6 years ago
|
Flags: needinfo?(apavel)
|
|
||
Comment 6•6 years ago
|
||
Aryx is there a way to solve the above using the web ui?
Flags: needinfo?(apavel) → needinfo?(aryx.bugmail)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/ae450d67977b
Add a tab color for the in-content.dark-mode mode. r=dao
|
||
Comment 8•6 years ago
|
||
Did |arc patch D27311 --nobranch| and took the committer information from https://hg.mozilla.org/comm-central/rev/4f2702e359aa
Flags: needinfo?(aryx.bugmail)
|
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
|
||
Updated•6 years ago
|
Whiteboard: [qa-68b-p2]
You need to log in
before you can comment on or make changes to this bug.
Description
•