Right now to use add_task you have to explicitly include this file (https://searchfox.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/AddTask.js) with:

• mochitest-chrome: <script src="chrome://mochikit/content/tests/SimpleTest/AddTask.js"></script>
• mochitest-plain: <script src="/tests/SimpleTest/AddTask.js"></script>

I think we should be including this anywhere that loads SimpleTest.js because:

1. add_task is a nicer way to work with tests (it automatically calls SimpleTest.waitForExplicitFinish, waits for load, is async by default)
2. the script doesn't have any side effects unless called
3. it's available by default in other suites (mochitest-browser, xpcshell)

My proposal is to move the contents of AddTask.js into SimpleTest.js and then remove the separate file and any references to it.

Script for removing <script> tags referencing AddTask.js

Haven't heard any feedback in https://groups.google.com/d/msg/mozilla.dev.platform/PqL0OC2C-90/15_zAj7_CgAJ, so I'm going to push up some patches to make this change.

This was generated with the script at https://bug1544051.bmoattachments.org/attachment.cgi?id=9058672

(In reply to Brian Grinstead [:bgrins] from comment #2)

Haven't heard any feedback in https://groups.google.com/d/msg/mozilla.dev.platform/PqL0OC2C-90/15_zAj7_CgAJ, so I'm going to push up some patches to make this change.

Joel, are you a good reviewer for this change, or could you recommend someone if not? I see you initially reviewed SpawnTask.js before it was renamed to AddTask.js: https://hg.mozilla.org/mozilla-central/log/22acceec0478/testing/mochitest/tests/SimpleTest/SpawnTask.js.

:ahal would be a good reviewer for this

https://hg.mozilla.org/mozilla-central/rev/77269915d66a
https://hg.mozilla.org/mozilla-central/rev/480e15689b61
https://hg.mozilla.org/mozilla-central/rev/c83490ca7185
https://hg.mozilla.org/mozilla-central/rev/dfe0b0d0827e