reader mode's voice select widget doesn't open if clicking the name of the selected voice
Categories
(Toolkit :: Reader Mode, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox66 | --- | wontfix |
firefox67 | --- | verified |
firefox68 | --- | verified |
People
(Reporter: asa, Assigned: Gijs)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
If you try to select a different voice by clicking on the name of the voice in the narrate panel, you don't get the pop-up for selecting alternate voices. You must click outside of the name of the voice, anywhere to the left or right in the gray box, to get the selector.
Tested in today's nightly build on x86 Windows 10
Assignee | ||
Comment 1•6 years ago
|
||
Wonder if this is a regression...
Assignee | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
mozregression pointed to https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f6eebcc14c22762f521fb567a9588963b8720592&tochange=61570c16c2d564c24fab36713fb169c4144453e9 with no more builds within this revset. Looks like bug 1089326.
Comment 5•6 years ago
|
||
bugherder |
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 9058266 [details]
Bug 1544065 - fix clicking on <span> tags inside voice selector in reader mode, r?eeejay
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: Bug 1089326
- User impact if declined: Selecting a different voice in reader mode fails to work properly in some situations
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment #0 / the subject of the bug. Clicking the text label of the voice select (as opposed to the whitespace around the text label) should also open the dropdown, and allow selecting a different voice.
- List of other uplifts needed: n/a
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Single-line fix that makes sense given the regressing bug
- String changes made/needed: None
Assignee | ||
Updated•6 years ago
|
Comment 7•6 years ago
|
||
Comment on attachment 9058266 [details]
Bug 1544065 - fix clicking on <span> tags inside voice selector in reader mode, r?eeejay
Low risk, uplift approved for 67 beta 12, thanks.
Updated•6 years ago
|
Comment 8•6 years ago
|
||
bugherder uplift |
Updated•6 years ago
|
Comment 9•6 years ago
|
||
Verified, that the issue is not reproducible on Nightly 68(20190417214729) an Windows 10 x64, MacOS 10.13 and Ubuntu 18.04
I'll verify it on 67 beta 12 also, when it will be available.
Comment 10•6 years ago
|
||
Verified, that the issue is not reproducible on Beta 67(20190418160535) on Windows 10 x64, MacOS 10.13 and Ubuntu 18.04
Updated•6 years ago
|
Updated•3 years ago
|
Description
•