Convert SourceClient to a Protocol.js front
Categories
(DevTools :: Framework, task, P3)
Tracking
(firefox68 fixed)
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: yulia, Assigned: yulia)
References
Details
(Whiteboard: dt-fission)
Attachments
(5 files)
Part of migrating the ThreadClient to a front is simplifying its API. The sourceClient is a dependancy of the threadclient and migrating it to a front before migrating threadclient would make that work easier. We already have the spec file https://searchfox.org/mozilla-central/source/devtools/shared/specs/source.js
File to be converted: https://searchfox.org/mozilla-central/source/devtools/shared/client/source-client.js
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
We had an alias for the blackbox method in the old client, to name it blackBox. this is
a pretty minimal change but the discrepency is confusing. I switched everything to be blackbox as
it is consistent with the server.
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc739beb6782 remove unused method 'getExecutableLines' from sourceClient; r=ochameau,jdescottes,loganfsmyth https://hg.mozilla.org/integration/autoland/rev/63d133aae187 remove unused client getters 'request' and '_transport' from sourceClient; r=ochameau,jdescottes
|
||
Comment 7•5 years ago
|
||
Backed out 2 changesets (bug 1544694) for XPCshell failures in devtools/server/tests/unit/test_blackboxing-01.js. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=241986546&repo=autoland&lineNumber=2030
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=241972235&revision=63d133aae187fde835f9f9a0b9f83bdbada8dcd8
Backout:
https://hg.mozilla.org/integration/autoland/rev/d6cdc1f35851af085218a5306a171599c92885fb
|
|
Assignee | |
Comment 8•5 years ago
|
||
Thanks, looks like the second patch needs to be part of the change to front.
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66fe93fc552c remove unused method 'getExecutableLines' from sourceClient; r=ochameau,jdescottes,loganfsmyth
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 11•5 years ago
|
||
|
||
Comment 12•5 years ago
|
||
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c36551d262a remove unused client getters 'request' and '_transport' from sourceClient; r=ochameau,jdescottes https://hg.mozilla.org/integration/autoland/rev/27e6d1a417e2 Convert Source Client to a Front; r=ochameau,jdescottes https://hg.mozilla.org/integration/autoland/rev/96682cfce65c move and rename SourceClient to SourceFront; r=ochameau,jdescottes
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 13•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9c36551d262a
https://hg.mozilla.org/mozilla-central/rev/27e6d1a417e2
https://hg.mozilla.org/mozilla-central/rev/96682cfce65c
|
||
Updated•5 years ago
|
Description
•