Closed
Bug 1544932
Opened 5 years ago
Closed 5 years ago
In-content dialogs in Prefs don't close with "Cancel"
Categories
(Thunderbird :: Preferences, defect)
Thunderbird
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 68.0
People
(Reporter: Paenglab, Assigned: darktrojan)
References
(Regression)
Details
Attachments
(1 file)
|
(deleted),
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
The dialogs in the prefs do no more close when clicking on "Cancel". No error in console.
Last good 20190415
First bad 20190416
It seems a regression from bug 1541789 because disabling Lightning makes the "Cancel" working again.
|
||
Updated•5 years ago
|
Flags: needinfo?(geoff)
|
Assignee | |
Comment 1•5 years ago
|
||
It seems a regression from bug 1541789 because disabling Lightning makes the "Cancel" working again.
That's very interesting. I wonder why.
Flags: needinfo?(geoff)
|
|
Assignee | |
Comment 2•5 years ago
|
||
Oh. I screwed up, that's why.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Reason number 407 why tab contents should be separated from the main document.
|
||
Updated•5 years ago
|
Attachment #9058809 -
Flags: review?(philipp) → review+
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/4a2e39cfc820
Stop applying dialog cancel handler to the main window; r=Fallen DONTBUILD
|
|
Assignee | |
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 68.0
You need to log in
before you can comment on or make changes to this bug.
Description
•