Closed
Bug 1544998
Opened 6 years ago
Closed 5 years ago
Search bar autocomplete popup has poor contrast in dark mode
Categories
(Firefox :: Theme, defect, P3)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
People
(Reporter: yoasif, Unassigned)
References
Details
(Keywords: nightly-community, Whiteboard: fixed by bug 1561894)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
image/png
|
Details |
search bar contrast.png
STR:
- enable browser.in-content.dark-mode
- Enable separate search bar
- Type something into the search bar
What happens:
The colors and contrast in the search bar does not look good.
Expected result:
Text should have better contrast, colors should look better.
|
Reporter | |
Updated•6 years ago
|
Blocks: dark-incontent-pages
Keywords: nightly-community
|
||
Comment 1•6 years ago
|
||
Sorry if I'm missing something, but which search bar looks wrong and how is it supposed to look like ?
Flags: needinfo?(yoasif)
|
||
Updated•6 years ago
|
Priority: -- → P5
|
|
Reporter | |
Comment 2•6 years ago
|
||
Ooops, forgot that taking a screenshot of a window won't take a screenshot of the search popup.
Attachment #9058839 -
Attachment is obsolete: true
Flags: needinfo?(yoasif)
|
|
||
Comment 3•6 years ago
|
||
Thanks for the screenshot!
This doesn't seem related the in-content dark mode, since this UI is styled even without.
No longer blocks: dark-incontent-pages
Summary: Search bar in dark mode has bad contrast/styling → Search bar autocomplete popup in dark mode has poor contrast
|
|
||
Comment 4•6 years ago
|
||
So the problem is that searchbar.inc.css uses --panel-disabled-color for text that isn't disabled.
Priority: P5 → P3
Summary: Search bar autocomplete popup in dark mode has poor contrast → Search bar autocomplete popup has poor contrast in dark mode
|
|
||
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Depends on: 1561894
Resolution: --- → FIXED
Whiteboard: fixed by bug 1561894
You need to log in
before you can comment on or make changes to this bug.
Description
•