Implement DOM.getBoxModel
Categories
(Remote Protocol :: CDP, enhancement, P1)
Tracking
(Not tracked)
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
https://chromedevtools.github.io/devtools-protocol/tot/DOM#method-getBoxModel
DOM.getBoxModel
Returns boxes for the given node.
This is being used from Wordpress test suite over here:
https://github.com/WordPress/gutenberg/blob/master/packages/e2e-tests/specs/links.test.js#L469
const settings = await page.$( '.block-editor-url-popover__settings' );
const bounds = await settings.boundingBox();
https://github.com/GoogleChrome/puppeteer/blob/5ee21d97e796263857b9f3fbeaf63366179d346f/lib/JSHandle.js#L309-L310
https://github.com/GoogleChrome/puppeteer/blob/5ee21d97e796263857b9f3fbeaf63366179d346f/lib/JSHandle.js#L222-L223
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Unfortunately, I'm not able to fix the tests on all platforms because of results being differents between high-dpi versus normal dpi.
On top of that with high-dpi, I get decimals and I'm not sure chromium exposes decimal pixels.
So. I'll try to proceed with the code while keeping the tests for followups.
This apply to this bug as well as bug 1549063.
Comment 4•5 years ago
|
||
bugherder |
Updated•4 years ago
|
Description
•