Closed Bug 1545916 Opened 6 years ago Closed 6 years ago

Match highlighting shouldn't be case-sensitive

Categories

(Firefox :: Address Bar, defect, P2)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Iteration:
68.3 - Apr 15 - 28
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: dao, Assigned: adw)

References

Details

Attachments

(1 file)

Bug 1545916 - Make quantumbar match highlighting case insensitive.
(deleted), text/x-phabricator-request
Details

It seems that quantumbar's match highlighting is case-sensitive whereas the old urlbar isn't.

Points: --- → 2
Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 68.3 - Apr 15 - 28
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2fb18533192e Make quantumbar match highlighting case insensitive. r=dao

Backed out changeset 2fb18533192e (Bug 1545916) for test_tokenizer.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Cdebug%2Cxpcshell%2Ctests%2Ctest-linux64%2Fdebug-xpcshell-e10s-1%2Cx%28x1%29&fromchange=24740ab9a7266f84283b2beeebe665edf903f09f&tochange=e2ee2fb416dc1d46529cf63269dcdef7a45c27ae&selectedJob=242644191

Backout link: https://hg.mozilla.org/integration/autoland/rev/e2ee2fb416dc1d46529cf63269dcdef7a45c27ae

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242644191&repo=autoland&lineNumber=2004

task 2019-04-25T16:44:59.296Z] 16:44:59 INFO - TEST-PASS | devtools/client/shared/test/unit/test_cssColor-02.js | took 72437ms
[task 2019-04-25T16:44:59.353Z] 16:44:59 INFO - Retrying tests that failed when run in parallel.
[task 2019-04-25T16:44:59.354Z] 16:44:59 INFO - TEST-START | browser/components/urlbar/tests/unit/test_tokenizer.js
[task 2019-04-25T16:45:00.255Z] 16:45:00 WARNING - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/unit/test_tokenizer.js | xpcshell return code: 0
[task 2019-04-25T16:45:00.255Z] 16:45:00 INFO - TEST-INFO took 896ms
[task 2019-04-25T16:45:00.257Z] 16:45:00 INFO - >>>>>>>
[task 2019-04-25T16:45:00.257Z] 16:45:00 INFO - PID 11106 | [11106, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, NS_ERROR_UNEXPECTED) failed with result 0x80004005: file /builds/worker/workspace/build/src/extensions/cookie/nsPermissionManager.cpp, line 1026
[task 2019-04-25T16:45:00.258Z] 16:45:00 INFO - PID 11106 | [11106, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/workspace/build/src/toolkit/crashreporter/nsExceptionHandler.cpp, line 2528
[task 2019-04-25T16:45:00.259Z] 16:45:00 INFO - PID 11106 | [11106, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, kKnownEsrVersion) failed with result 0x80004002: file /builds/worker/workspace/build/src/toolkit/components/resistfingerprinting/nsRFPService.cpp, line 662
[task 2019-04-25T16:45:00.259Z] 16:45:00 INFO - PID 11106 | [11106, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /builds/worker/workspace/build/src/extensions/cookie/nsPermissionManager.cpp, line 2910
[task 2019-04-25T16:45:00.260Z] 16:45:00 INFO - PID 11106 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 3482: ReferenceError: reference to undefined property "process"
[task 2019-04-25T16:45:00.261Z] 16:45:00 INFO - PID 11106 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 11041: ReferenceError: reference to undefined property "Object"
[task 2019-04-25T16:45:00.262Z] 16:45:00 INFO - PID 11106 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 12088: ReferenceError: reference to undefined property "Buffer"
[task 2019-04-25T16:45:00.262Z] 16:45:00 INFO - PID 11106 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 16620: TypeError: Symbol.toStringTag is read-only
[task 2019-04-25T16:45:00.264Z] 16:45:00 INFO - PID 11106 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 16620: TypeError: Symbol.toStringTag is read-only
[task 2019-04-25T16:45:00.264Z] 16:45:00 INFO - PID 11106 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 16620: TypeError: Symbol.toStringTag is read-only
[task 2019-04-25T16:45:00.265Z] 16:45:00 INFO - PID 11106 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 16620: TypeError: Symbol.toStringTag is read-only
[task 2019-04-25T16:45:00.265Z] 16:45:00 INFO - PID 11106 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 16620: TypeError: Symbol.toStringTag is read-only
[task 2019-04-25T16:45:00.266Z] 16:45:00 INFO - PID 11106 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 6247: ReferenceError: reference to undefined property "iso-8859-8-i"
[task 2019-04-25T16:45:00.267Z] 16:45:00 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-04-25T16:45:00.268Z] 16:45:00 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2019-04-25T16:45:00.269Z] 16:45:00 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2019-04-25T16:45:00.269Z] 16:45:00 INFO - running event loop

Flags: needinfo?(adw)

Sorry, forgot that this potentially affected xpcshell tests when I ran this on try (even though I modified an xpcshell test...)

Flags: needinfo?(adw)
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b8a2f9ec207 Make quantumbar match highlighting case insensitive. r=dao

https://hg.mozilla.org/mozilla-central/rev/1b8a2f9ec207

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: