[de-xbl] remove the (forked) toolbarpaletteitem and toolbarpaletteitem-palette bindings
Categories
(Thunderbird :: Toolbars and Tabs, task)
Tracking
(Not tracked)
People
(Reporter: mkmelin, Assigned: aleca)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Remove the toolbarpaletteitem binding: https://searchfox.org/comm-central/rev/024094c2ebc05723d2b0da86086539d5b97044cb/common/bindings/toolbar.xml#541
This was done in bug 1507875 for Firefox https://hg.mozilla.org/mozilla-central/rev/8f7476054232, and we should do the same. The commit comment explains the story.
|
Reporter | |
Comment 1•6 years ago
|
||
We do need to adjust this: https://searchfox.org/comm-central/rev/024094c2ebc05723d2b0da86086539d5b97044cb/common/src/customizeToolbar.js#221
|
|
Reporter | |
Comment 2•6 years ago
|
||
Looks like toolbarpaletteitem-palette would go at the same time
https://searchfox.org/comm-central/rev/024094c2ebc05723d2b0da86086539d5b97044cb/mail/base/content/bindings.css#32 (some adjustments may be needed)
|
Assignee | |
Comment 3•5 years ago
|
||
I think I got all the CSS updates and implemented the same approach done in FF.
I can't seem to figure out what can be removed from the unwrapToolbarItems() method as the outcome seems to be always the same even if I completely remove that method.
Do you know what's the purpose of that method and how is supposedly changing the markup?
|
|
Assignee | |
Updated•5 years ago
|
|
|
Reporter | |
Comment 4•5 years ago
|
||
Comment on attachment 9069550 [details] [diff] [review] dexbl-toolbarpaletteitem.patch Review of attachment 9069550 [details] [diff] [review]: ----------------------------------------------------------------- Looks ok. Maybe unwrapToolbarItem doesn't need to be adjusted. I don't know if it's really needed...
|
|
Assignee | |
Comment 5•5 years ago
|
||
Nevermind, the unwrapToolbarItems is necessary to make the toolbar buttons usable once added. Without it, the drag and drop overlay doesn't get removed.
This should be ready for a review.
|
|
Reporter | |
Comment 6•5 years ago
|
||
Comment on attachment 9073056 [details] [diff] [review] dexbl-toolbarpaletteitem.patch Review of attachment 9073056 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, r=mkmelin
|
|
Assignee | |
Updated•5 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/451a275be8a6
[de-xbl] remove toolbarpaletteitem and toolbarpaletteitem-palette bindings. r=mkmelin
|
||
Updated•5 years ago
|
Description
•