Wasm baseline compiler: fix inconsistent indexing in MachineStackTracker::{set,is}GCPointer
Categories
(Core :: JavaScript: WebAssembly, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: jseward, Assigned: jseward)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
MachineStackTracker::setGCPointer claims in a comment that its argument
|offsetFromSP| is an index up from the lowest address denoted by the stack
map. It implements that consistently with the comment.
MachineStackTracker::isGCPointer makes the same claim in a comment, but
actually implements the indexing in the opposite direction.
|
Assignee | |
Comment 1•6 years ago
|
||
MachineStackTracker::setGCPointer claims in a comment that its argument
|offsetFromSP| is an index up from the lowest address denoted by the stack
map. It implements that consistently with the comment.
MachineStackTracker::isGCPointer makes the same claim in a comment, but
actually implements the indexing in the opposite direction.
This patch:
-
inverts the indexing direction of ::isGCPointer, making it consistent with
the comments and with ::setGCPointer -
changes the one-and-only use point of ::isGCPointer, in createStackMap(),
accordingly. Rather than change the argument to ::isGCPointer, the
iteration direction of the containing loop is inverted, since that fits
better with the surrounding code.
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
|
||
Updated•6 years ago
|
Description
•