FXA-related snippets should not snow up if Firefox Accounts are disabled
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | verified |
People
(Reporter: k88hudson, Assigned: andreio)
References
Details
(Keywords: github-merged)
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
This is is related to enterprise settings:
If the identity.fxaccounts.enabled pref is false, we shouldn't be showing FXA snippets at all:
https://searchfox.org/mozilla-central/source/browser/components/enterprisepolicies/Policies.jsm#312
(this might be covered by our targeting already just filing to make sure)
Reporter | ||
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
This patch will add a new targeting attribute that checks if FxA services are disabled.
Snippets that use usesFirefoxSync
should be updated. My suggestion would be:
// This way we don't have to worry about targeting specific versions that have the attribute
usesFirefoxSync && (isFxAEnabled == undefined || isFxAEnabled == true)
Comment 3•6 years ago
|
||
(In reply to Andrei Oprea [:andreio] from comment #2)
This patch will add a new targeting attribute that checks if FxA services are disabled.
Snippets that useusesFirefoxSync
should be updated. My suggestion would be:// This way we don't have to worry about targeting specific versions that have the attribute usesFirefoxSync && (isFxAEnabled == undefined || isFxAEnabled == true)
Can we apply this new JEXL now, without affecting the behavior in older versions of Fx?
Assignee | ||
Comment 4•6 years ago
|
||
Yes, if we ignore when the attribute is undefined it should not affect older version of Firefox.
Comment 5•6 years ago
|
||
Comment 6•6 years ago
|
||
The issue is not actionable right now, because the only snippet present in Nightly is the "Special FxA" one (displayed under the in-content Search Bar) that has no targeting parameters set and is displayed on each New Tab page regardless of the "identity.fxaccounts.enabled" pref's value. Considering this I will leave a ni? on myself in order to verify this issue later.
Comment 7•6 years ago
|
||
I have verified that this issue is no longer reproducible with the latest Firefox Nightly (68.0a1 Build ID - 20190509033505) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the "Special FxA" snippet is no longer displayed if the "identity.fxaccounts.enabled" pref is set to false.
Updated•5 years ago
|
Description
•