Convert TestZip to a gtest
Categories
(Core :: mozglue, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
We're going to convert the test to a gtest, and it's simpler not to have
to deal with finding the path to the testcase zip files. They're small
enough anyways, and can be inserted as raw binary data via some assembly
magic. This being android-only code, we don't need extreme portability
here. This is the same trick we use in
config/external/icu/data/icudata_gas.S.
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/28c357e15e37
https://hg.mozilla.org/mozilla-central/rev/a18a147e0dee
https://hg.mozilla.org/mozilla-central/rev/40ea57b79736
|
||
Comment 6•6 years ago
|
||
This change has broken building for android with icecc for me. I get the following error:
4:18.62 <inline asm>:5:11: error: Could not find incbin file '/home/jamie/src/gecko/mozglue/linker/tests/test.zip'
4:18.62 .incbin "/home/jamie/src/gecko/mozglue/linker/tests/test.zip"
4:18.62 ^
4:18.62 <inline asm>:17:11: error: Could not find incbin file '/home/jamie/src/gecko/mozglue/linker/tests/no_central_dir.zip'
4:18.62 .incbin "/home/jamie/src/gecko/mozglue/linker/tests/no_central_dir.zip"
4:18.62 ^
Googling "incbin icecc" doesn't return much, but does find this qt change - https://codereview.qt-project.org/#/c/85416/ - which states that icecc and incbin are incompatible. Not sure whether that's strictly true or whether it just needs some work, this is well outside of my area of expertise.
Is there a mozconfig option or a line of code I can comment out to avoid invoking this?
Description
•