Fix "None" checks when validating test manifests
Categories
(Testing :: Raptor, defect, P1)
Tracking
(firefox68 fixed)
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
For streaming tests we cannot always run them through mitmproxy and a recorded playback pageset manifest. As such using the option use_live_sites
in the manifest shouldn't require the playback_pageset_manifest
and playback_recordings
entries:
09:49:37 INFO - raptor-manifest /Users/henrik/code/gecko/testing/raptor/raptor/raptor.ini
09:49:37 INFO - raptor-manifest configuring settings for test raptor-stream-youtube-firefox
09:49:37 INFO - raptor-manifest using live sites so turning playback off!
09:49:37 INFO - raptor-manifest using live sites so appending '-live' to the test name
09:49:37 INFO - raptor-manifest ERROR: setting 'playback_pageset_manifest' is required but not found in /Users/henrik/code/gecko/testing/raptor/raptor/tests/raptor-stream-youtube.ini
09:49:37 INFO - raptor-manifest ERROR: setting 'playback_recordings' is required but not found in /Users/henrik/code/gecko/testing/raptor/raptor/tests/raptor-stream-youtube.ini
09:49:37 INFO - raptor-manifest test raptor-stream-youtube-firefox-live is not valid due to missing settings
09:49:37 INFO - raptor-main abort: no tests found
Assignee | ||
Comment 1•5 years ago
|
||
Problem is that playback
in test_details
is None, and that is not covered by the condition above:
Other checks suffer from the same problem. So I'm going to fix all of them.
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Updated•5 years ago
|
Comment 6•5 years ago
|
||
bugherder |
Description
•