[Card] Adjust vertical spacing and text color
Categories
(Firefox :: New Tab Page, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | verified |
People
(Reporter: wolasi, Assigned: gsuntop)
References
Details
(Keywords: github-merged)
Attachments
(2 files, 4 obsolete files)
Screen Shot 2019-04-26 at 13.37.10-fullpage.png
Make the following changes for all cards
Requirements
- For 4-column card size, title font-size should be 15px
- Change excerpt text color to gray-90 (gray-10 for dark theme)
- Remove vertical spacing between title and excerpt
- Change text color of sponsored by label to gray-50 (gray-40 for dark theme)
- See spec for vertical spacing adjustments
Spec
https://www.figma.com/file/0xZkmT86rSXbGRB4eIvrn0ts/New-Tab-Spec-for-Fx-v68?node-id=442%3A1
Colors
https://www.figma.com/file/HAk87Z6QBcu6YxBIoXN6LJcU/Firefox-New-Tab-Components?node-id=41%3A256
|
Assignee | |
Updated•6 years ago
|
|
||
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
|
Reporter | |
Comment 3•6 years ago
|
||
Hard to tell from the screenshot but…
- Was an adjustment made to the vertical spacing between the image and the title? Should be 12px per the spec
- Similarly the min vertical spacing between the excerpt and the "Sponsored by…" label
Also can we get a screenshot of layout with 3-colum card layout for review?
|
||
Updated•6 years ago
|
|
|
Assignee | |
Comment 4•6 years ago
|
||
(In reply to Wolasi from comment #3)
Hard to tell from the screenshot but…
- Was an adjustment made to the vertical spacing between the image and the title? Should be 12px per the spec
Will make that tweak.
- Similarly the min vertical spacing between the excerpt and the "Sponsored by…" label
There is a 12px min margin there. Did you want something else?
Also can we get a screenshot of layout with 3-colum card layout for review?
Will add this!
|
|
Assignee | |
Comment 5•6 years ago
|
||
|
|
Reporter | |
Comment 6•6 years ago
|
||
- Source color for the largest story in the hero should be gray
- Remove spacing between title and excerpt for the largest hero story
- Vertical spacing between image and text below should 12px
- Vertical spacing between the excerpt and the Sponsor label should be 10px
|
|
Assignee | |
Comment 7•6 years ago
|
||
|
|
Reporter | |
Comment 8•6 years ago
|
||
Looking good! We might as well change the source and sponsor text for list items too.
|
|
Assignee | |
Comment 9•6 years ago
|
||
Tweaked list colors.
|
|
Reporter | |
Comment 10•6 years ago
|
||
Text excerpt color for hero main story should be gray-90 (gray-10 for dark theme)
|
|
Assignee | |
Comment 11•6 years ago
|
||
|
|
Reporter | |
Comment 12•6 years ago
|
||
LGTM
|
|
||
Comment 13•6 years ago
|
||
|
||
Comment 14•6 years ago
|
||
I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190509214305) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the cards are respecting the changes from comment 0.
|
|
Reporter | |
Updated•6 years ago
|
|
||
Updated•5 years ago
|
Description
•