Closed
Bug 1546934
Opened 6 years ago
Closed 5 years ago
Make code coverage use a process-wide flag
Categories
(Core :: JavaScript Engine, task)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In Realm::collectCoverageForDebug we check:
return debuggerObservesCoverage() ||
runtimeFromAnyThread()->profilingScripts ||
runtimeFromAnyThread()->lcovOutput().isEnabled();
The last two are used when either (1) the JS_CODE_COVERAGE_OUTPUT_DIR environment variable is set or (2) the --code-coverage flag is used in the shell.
Both of those conditions affect all runtimes in the process, so we can simplify them to a single global flag that's initialized before any runtimes are created.
Having this flag will simplify the Baseline Interpreter work.
|
Assignee | |
Comment 1•6 years ago
|
||
This will simplify the Baseline Interpreter work.
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24740ab9a726
Change LCov code coverage machinery to use a process-wide flag. r=nbp
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•